WordPress.org

Make WordPress Core

Opened 6 years ago

Closed 5 years ago

#5614 closed defect (bug) (wontfix)

Extra line in function end_el causes an extra gap in horizontal lists

Reported by: jashnu Owned by:
Milestone: Priority: low
Severity: minor Version: 2.3.2
Component: General Keywords: has-patch
Focuses: Cc:

Description

wp-includes/classes.php lines 535-541:

function end_el($output, $page, $depth) {

$output .= "</li>\n";

return $output;

}

}

\n causes an extra gap if you create a horizontal list so \n should be removed.

Attachments (1)

end_el-nonl.patch (329 bytes) - added by gtim 6 years ago.

Download all attachments as: .zip

Change History (6)

comment:1 lloydbudd6 years ago

  • Milestone changed from 2.3.3 to 2.5

comment:2 in reply to: ↑ description sivel6 years ago

I'm not sure I agree with making this change. Making this change will place all li tags on one line which does not follow best practice for lists.

comment:3 lloydbudd6 years ago

  • Milestone changed from 2.5 to 2.6

gtim6 years ago

comment:4 gtim6 years ago

  • Keywords has-patch added

Added a patch in case it is decided that the advantages of removing \n outweighs not following the best practice.

comment:5 Denis-de-Bernardy5 years ago

  • Milestone 2.9 deleted
  • Resolution set to wontfix
  • Status changed from new to closed

the \n or a space is needed for accessibility. if it is not present, a text reader will potentially read the entire list as "foobar" (single word) instead of "foo" "bar".

Note: See TracTickets for help on using tickets.