Make WordPress Core

Opened 2 years ago

Closed 2 years ago

Last modified 2 years ago

#56146 closed defect (bug) (duplicate)

unescaped 'home_url()' in 'wp-admin/themes.php' file in 'line 273'

Reported by: shraboni's profile shraboni Owned by:
Milestone: Priority: normal
Severity: normal Version:
Component: Themes Keywords: has-patch
Focuses: administration Cc:


Hey everyone. 🙂
It's my first ticket at WordPress core.

I've found that in 'wp-admin/themes.php' file, in line number 273 there's 'home_url()' used without escaping. I think it should be escaped.

Attachments (1)

56146.patch (707 bytes) - added by msnewas 2 years ago.
Thanks for bringing it up. this should do the job.

Download all attachments as: .zip

Change History (11)

#1 @hztyfoon
2 years ago

Hey @shraboni, welcome to WordPress core. thanks for your contribution to WordPress. Hope you'll continue your contribution.

2 years ago

Thanks for bringing it up. this should do the job.

#2 @hztyfoon
2 years ago

  • Keywords has-patch added

#3 @costdev
2 years ago

  • Milestone changed from Awaiting Review to 6.1
  • Version trunk deleted

Hi @shraboni, welcome to Trac! Thanks for opening this ticket.

Thanks for the patch @msnewas. It looks good to me.

#4 @costdev
2 years ago

  • Keywords commit added

#5 @desrosj
2 years ago

  • Component changed from Administration to Themes
  • Focuses coding-standards removed
  • Keywords add-to-field-guide removed

#6 @costdev
2 years ago

Related ticket: #56145

#7 @hztyfoon
2 years ago

Related ticket: #56132, #56133, #56146

#8 @hztyfoon
2 years ago

hey @msnewas,
U're more than welcome to WordPress contribution.
Thanks for your patch. It looks good to me. 👍

#9 @desrosj
2 years ago

  • Keywords commit removed
  • Milestone 6.1 deleted
  • Resolution set to duplicate
  • Status changed from new to closed

Thanks for opening this ticket @shraboni.

This ticket is very similar to #56145, and this instance is being addressed there. I'm going to close this as a duplicate, but all contributors will receive credit in the commit that fixes this occurrence.

Contributions in any form are always welcome. But in the future, please try to avoid opening tickets for single line fixes unless they're truly one offs. A preferred approach would be to check the entire file for other instances of the same or similar problems, or even entire segments of the code base and address them all in one ticket. This makes it much easier to get these fixes finished and committed, and reduces the noise that opening similar issues can cause.

#10 @shraboni
2 years ago

Thanks for your kind words @desrosj

Note: See TracTickets for help on using tickets.