unescaped 'home_url()' in 'wp-admin/themes.php' file in 'line 273'

[shraboni]

Hey everyone. 🙂
It's my first ticket at WordPress core.

I've found that in 'wp-admin/themes.php' file, in line number 273 there's 'home_url()' used without escaping. I think it should be escaped.

[hztyfoon]

Hey @shraboni, welcome to WordPress core. thanks for your contribution to WordPress. Hope you'll continue your contribution.

[msnewas]

Thanks for bringing it up. this should do the job.

[costdev]

Hi @shraboni, welcome to Trac! Thanks for opening this ticket.

Thanks for the patch @msnewas. It looks good to me.

[costdev]

Related ticket: #56145

[hztyfoon]

Related ticket: #56132, #56133, #56146

[hztyfoon]

hey @msnewas,
U're more than welcome to WordPress contribution.
Thanks for your patch. It looks good to me. 👍

[desrosj]

Thanks for opening this ticket @shraboni.

This ticket is very similar to #56145, and this instance is being addressed there. I'm going to close this as a duplicate, but all contributors will receive credit in the commit that fixes this occurrence.

Contributions in any form are always welcome. But in the future, please try to avoid opening tickets for single line fixes unless they're truly one offs. A preferred approach would be to check the entire file for other instances of the same or similar problems, or even entire segments of the code base and address them all in one ticket. This makes it much easier to get these fixes finished and committed, and reduces the noise that opening similar issues can cause.

[shraboni]

Thanks for your kind words @desrosj