Opened 4 years ago
Closed 2 years ago
#56157 closed defect (bug) (fixed)
Twenty Twenty: Table font size not reflected in frontend
| Reported by: | umesh84 | Owned by: | karmatosed |
|---|---|---|---|
| Priority: | normal | Milestone: | 6.7 |
| Component: | Bundled Theme | Version: | 6.0 |
| Severity: | normal | Keywords: | has-screenshots has-patch needs-testing commit |
| Cc: | Focuses: | css |
Description
Twenty Twenty Table font size not reflected in front.
Steps to replicate:
1: Activate the Twenty Twenty Themes
2: add Table block
3: Select Size
URL: https://www.loom.com/share/dc28c0c09ef247e1afe55a0561c1c911
Attachments (4)
Change History (22)
This ticket was mentioned in PR #2953 on WordPress/wordpress-develop by pratiweb.
4 years ago
#1
- Keywords has-patch added; needs-patch removed
Solved issue #56157
Change font size to inherit in Twenty Twenty Table style.
#2
@
4 years ago
- Summary Themes: Twenty Twenty Table font size not reflected in frontend → Twenty Twenty: Table font size not reflected in frontend
#4
@
3 years ago
- Keywords needs-testing added
The font size needs to stay the same for any tables or Table blocks that do not use the custom block setting.
#5
@
3 years ago
- Keywords has-screenshots added
Test Report For https://core.trac.wordpress.org/attachment/ticket/56157/56157.2.patch Patch.
Table blocks that do not use the custom block setting:
=============================================
Back-end : https://prnt.sc/SaHZm1N4S9R4
Front-end : https://prnt.sc/XaLdVqdWIJPc
Table Block when user selects a font size:
===================================
Backend: https://prnt.sc/tDHPsfHRZJ_d
Frontend :
=========
Before Patch Frontend: https://prnt.sc/mLm3vEz9V3Mp
After Patch Frontend : https://prnt.sc/IH4Vk28EVTTg
https://core.trac.wordpress.org/attachment/ticket/56157/56157.2.patch Patch is Working Fine.
Result After Patch:
- Table font size is reflected in frontend same as backend (When User select a custom font size)
- Table blocks font size stay same when do not use the custom block setting
#6
@
2 years ago
Assigning so I can review this and look to see if it still is an issue, that the patch works and if it could be a candidate for commit.
#8
@
2 years ago
- Keywords close added; needs-testing commit removed
In testing this, the issue has been resolved with previous patches or at least seems to have been. I tested it both using 10 and 100px in custom size and both times it was without the patch working.
I am going to recommend this is closed for now but very happy for others to correct that if they can replicate the issue. To be clear I followed these instructions:
1: Activate the Twenty Twenty Themes
2: add Table block
3: Select Size
#10
@
2 years ago
- Milestone Future Release
- Resolution → worksforme
- Status new → closed
Thank you everyone. For now I am going to close this.
@
2 years ago
(without patch) custom font sizes still do not override the theme's table styles on the front end
#11
@
2 years ago
- Keywords needs-testing added; close removed
- Milestone → Future Release
- Resolution worksforme
- Status closed → reopened
Changing the font size already works in the editor, but still not on the front.
#13
@
2 years ago
@karmatosed
56157.2.patch changes are pending in this ticket.
Because in Changeset 58819 only Calander block changes are added Still table block font size changes are in pending.
#14
@
2 years ago
- Resolution fixed
- Status closed → reopened
@shailu25 very happy to reopen but I did see it working for custom font sizes. Let's get some testing on the reopen with the commit now in.
#15
@
2 years ago
Steps to Replicate the Table Block Font Size Issue in the Frontend:
- Activate the Twenty Twenty theme.
- Add a Table block in a page or post.
- Select a custom font size (e.g., 32 or Large Font) and save the page or post.
- Check the frontend; you will see that the custom font size is not applied to the Table block.
#17
@
2 years ago
- Keywords commit added
- Milestone Future Release → 6.7
- Status reopened → assigned
I can confirm in testing the latest patch works and that the front end and back end now have the custom font changes. I am therefore going to move this to commit. Thank you everyone and thank you for catching it wasn't cleared up in the previous solutions.
![(please configure the [header_logo] section in trac.ini)](/chrome/site/your_project_logo.png)
added patch