Make WordPress Core

Opened 4 years ago

Closed 2 years ago

#56157 closed defect (bug) (fixed)

Twenty Twenty: Table font size not reflected in frontend

Reported by: umesh84 Owned by: karmatosed
Priority: normal Milestone: 6.7
Component: Bundled Theme Version: 6.0
Severity: normal Keywords: has-screenshots has-patch needs-testing commit
Cc: Focuses: css

Description

Twenty Twenty Table font size not reflected in front.

Steps to replicate:
1: Activate the Twenty Twenty Themes

2: add Table block

3: Select Size

URL: ​https://www.loom.com/share/dc28c0c09ef247e1afe55a0561c1c911

Attachments (4)

#56157.patch​ (396 bytes ) - added by umesh84 4 years ago.
added patch
56157.2.patch​ (1014 bytes ) - added by sabernhardt 3 years ago.
inheriting font size only when user selects a size in the Table block
2020-Table-block-font-size-front.png​ (112.8 KB ) - added by sabernhardt 2 years ago.
(without patch) custom font sizes still do not override the theme's table styles on the front end
SCR-20240729-kbru.png​ (51.1 KB ) - added by karmatosed 2 years ago.
Showing front end

Download all attachments as: .zip

Change History (22)

@umesh84
4 years ago

added patch

This ticket was mentioned in ​PR #2953 on ​WordPress/wordpress-develop by ​pratiweb.


4 years ago
#1

  • Keywords has-patch added; needs-patch removed

Solved issue #56157

Change font size to inherit in Twenty Twenty Table style.

#2 @SergeyBiryukov
4 years ago

  • Summary Themes: Twenty Twenty Table font size not reflected in frontend → Twenty Twenty: Table font size not reflected in frontend

@sabernhardt
3 years ago

inheriting font size only when user selects a size in the Table block

#3 @sabernhardt
3 years ago

#58489 was marked as a duplicate.

#4 @sabernhardt
3 years ago

  • Keywords needs-testing added

The font size needs to stay the same for any tables or Table blocks that do not use the custom block setting.

#5 @shailu25
3 years ago

  • Keywords has-screenshots added

Test Report For https://core.trac.wordpress.org/attachment/ticket/56157/56157.2.patch Patch.

Table blocks that do not use the custom block setting:
=============================================

Back-end : ​https://prnt.sc/SaHZm1N4S9R4
Front-end : ​https://prnt.sc/XaLdVqdWIJPc

Table Block when user selects a font size:
===================================

Backend: ​https://prnt.sc/tDHPsfHRZJ_d

Frontend :
=========
Before Patch Frontend: ​https://prnt.sc/mLm3vEz9V3Mp
After Patch Frontend : ​https://prnt.sc/IH4Vk28EVTTg

https://core.trac.wordpress.org/attachment/ticket/56157/56157.2.patch Patch is Working Fine.

Result After Patch:

  • Table font size is reflected in frontend same as backend (When User select a custom font size)
  • Table blocks font size stay same when do not use the custom block setting

#6 @karmatosed
2 years ago

Assigning so I can review this and look to see if it still is an issue, that the patch works and if it could be a candidate for commit.

#7 @karmatosed
2 years ago

  • Keywords commit added
  • Milestone Awaiting Review → 6.7

#8 @karmatosed
2 years ago

  • Keywords close added; needs-testing commit removed

In testing this, the issue has been resolved with previous patches or at least seems to have been. I tested it both using 10 and 100px in custom size and both times it was without the patch working.

I am going to recommend this is closed for now but very happy for others to correct that if they can replicate the issue. To be clear I followed these instructions:

1: Activate the Twenty Twenty Themes

2: add Table block

3: Select Size

#9 @karmatosed
2 years ago

  • Milestone 6.7 → Future Release

#10 @karmatosed
2 years ago

  • Milestone Future Release
  • Resolution → worksforme
  • Status new → closed

Thank you everyone. For now I am going to close this.

@sabernhardt
2 years ago

(without patch) custom font sizes still do not override the theme's table styles on the front end

#11 @sabernhardt
2 years ago

  • Keywords needs-testing added; close removed
  • Milestone → Future Release
  • Resolution worksforme
  • Status closed → reopened

Changing the font size already works in the editor, but still not on the front.

#12 @karmatosed
2 years ago

  • Owner set to karmatosed
  • Resolution → fixed
  • Status reopened → closed

In 58819:

Twenty Twenty: Calendar and Table blocks do not apply custom font size.

This fixes adding a custom font size to a Calendar and Table block. This was only an issue for custom font size entering.

Props nidhidhandhukiya, yurajsinj2211, ankit-k-gupta, anveshika, sabernhardt, darshitrajyaguru97, shailu25, umesh84, SergeyBiryukov.
Fixes #59996, #56157.

#13 @shailu25
2 years ago

@karmatosed

56157.2.patch changes are pending in this ticket.

Because in Changeset 58819 only Calander block changes are added Still table block font size changes are in pending.

Last edited 2 years ago by shailu25 (previous) (diff)

#14 @karmatosed
2 years ago

  • Resolution fixed
  • Status closed → reopened

@shailu25 very happy to reopen but I did see it working for custom font sizes. Let's get some testing on the reopen with the commit now in.

#15 @shailu25
2 years ago

Steps to Replicate the Table Block Font Size Issue in the Frontend:

  1. Activate the Twenty Twenty theme.
  2. Add a Table block in a page or post.
  3. Select a custom font size (e.g., 32 or Large Font) and save the page or post.
  4. Check the frontend; you will see that the custom font size is not applied to the Table block.

#16 @karmatosed
2 years ago

Ok going back into testing for this with those steps, thank you.

#17 @karmatosed
2 years ago

  • Keywords commit added
  • Milestone Future Release → 6.7
  • Status reopened → assigned

I can confirm in testing the latest patch works and that the front end and back end now have the custom font changes. I am therefore going to move this to commit. Thank you everyone and thank you for catching it wasn't cleared up in the previous solutions.

@karmatosed
2 years ago

Showing front end

#18 @karmatosed
2 years ago

  • Resolution → fixed
  • Status assigned → closed

In 58824:

Twenty Twenty: Fixes Table font size when custom showing on front.

The Table block was not reflecting the custom font size on the front. This solution now brings custom font sizes in for front the same as back in the editor.

Props umesh84, SergeyBiryukov, sabernhardt, shailu25.
Fixes #56157.

Note: See TracTickets for help on using tickets.