Make WordPress Core

Opened 2 years ago

Closed 4 weeks ago

#56174 closed defect (bug) (worksforme)

Twenty Twenty: button block overlaps with other block

Reported by: multidots1896's profile multidots1896 Owned by:
Milestone: Priority: normal
Severity: normal Version: 6.0
Component: Bundled Theme Keywords: has-patch
Focuses: Cc:

Description

While using twenty twenty theme facing issue when we add button block and changing its alignment and adding other search block.Button block overlap with other block.

Here is link:https://share.cleanshot.com/rITjL3ots1sSlhb1sXqE

Attachments (3)

56174.patch (714 bytes) - added by multidots1896 2 years ago.
added patch
56174.1.patch (2.0 KB) - added by nidhidhandhukiya 2 years ago.
56174.2.patch (1.0 KB) - added by smit08 2 years ago.
@nidhidhandhukiya patch was working but looks like that margin-bottom difference in different alignments was given intentionally, because I found margin-bottom css of different alignments. So I added the new patch. @multidots1896 forgot to add the rtl css so I added the same patch like like @multidots1896 but with rtl css file change

Download all attachments as: .zip

Change History (7)

@multidots1896
2 years ago

added patch

#1 @multidots1896
2 years ago

  • Version set to 6.0

#2 @desrosj
2 years ago

  • Summary changed from In Twenty Twenty theme button block overlap with other block to Twenty Twenty: button block overlaps with other block

#3 @nidhidhandhukiya
2 years ago

Hello @multidots1896
After applying your patch yes issue is solved But, the spacing is looking different for align-right, centre or left.
So for that, we need to remove the margin bottom from left and right.
I have added code for that in my patch.

@smit08
2 years ago

@nidhidhandhukiya patch was working but looks like that margin-bottom difference in different alignments was given intentionally, because I found margin-bottom css of different alignments. So I added the new patch. @multidots1896 forgot to add the rtl css so I added the same patch like like @multidots1896 but with rtl css file change

#4 @sabernhardt
4 weeks ago

  • Milestone Awaiting Review deleted
  • Resolution set to worksforme
  • Status changed from new to closed

Thanks for the report and patches. The legacy alignment classes have been replaced by text alignment and justification settings, so this should be unnecessary now.

I'll close this, as similar tickets have closed: #57257, #56138, #53021, #56601.

Note: See TracTickets for help on using tickets.