Make WordPress Core

Opened 2 years ago

Closed 2 years ago

Last modified 2 years ago

#56190 closed defect (bug) (fixed)

Plugins list: isufficent color contrast in plugin name, in recovery-mode.

Reported by: kebbet's profile kebbet Owned by: joedolson's profile joedolson
Milestone: 6.1 Priority: normal
Severity: normal Version:
Component: Plugins Keywords: has-patch has-screenshots commit
Focuses: ui, accessibility, css Cc:

Description

The texts ”Plugin name” and ”Resume” (a row action link) has insufficent color contrast in the plugins list, this is an accessibility issue.

Current color (#d63638) gives color contrast 4.40

If we use the delete color from the plugins list (#b32d2e) the color contrast is 5.87.

Attachments (3)

56190.png (497.4 KB) - added by kebbet 2 years ago.
Before and the suggested after.
Capture d’écran 2022-07-20 à 13.21.37.png (193.3 KB) - added by audrasjb 2 years ago.
Before patch
Capture d’écran 2022-07-20 à 13.23.37.png (180.3 KB) - added by audrasjb 2 years ago.
After patch

Download all attachments as: .zip

Change History (13)

@kebbet
2 years ago

Before and the suggested after.

This ticket was mentioned in Slack in #accessibility by kebbet. View the logs.


2 years ago

#2 @joedolson
2 years ago

  • Milestone changed from Awaiting Review to 6.1
  • Owner set to joedolson
  • Status changed from new to accepted

#3 @kebbet
2 years ago

And maybe update the left border to the same color, to make the three instances match.

This ticket was mentioned in PR #2960 on WordPress/wordpress-develop by mukeshpanchal27.


2 years ago
#4

  • Keywords has-patch added; needs-patch removed

#5 @mukesh27
2 years ago

Hi there!

I have added PR that fixed the color issue for the plugin list.

#6 @kebbet
2 years ago

The changes in the PR looks ok to me.

It is hard to test, but one way to do so is to

  • install the plugin WP Crontrol 1.12.1
  • activate the plugin
  • download version 1.13.2 and replace the existing plugin folder with the downloaded.
  • this should trigger a fatal error and activate the recovery mode. (Version 1.14 is fixed and does not trigger a fatal)

#7 @audrasjb
2 years ago

  • Keywords has-screenshots commit added

Looks good to go, thanks all.

#8 @audrasjb
2 years ago

  • Resolution set to fixed
  • Status changed from accepted to closed

In 53726:

Plugins: Improve color contrast on plugins screen when recovery mode is activated.

This changeset replaces #d63638 (contrast ratio: 4.40) with #b32d2e (contrast ratio: 5.87) in Plugins screen row action links when the site is in recovery mode.

Props kebbet, mukesh27, joedolson, audrasjb.
Fixes #56190.

#10 @audrasjb
2 years ago

Err… sorry @joedolson I just figured out that I committed #56190 although you were the ticket owner.

Version 1, edited 2 years ago by audrasjb (previous) (next) (diff)
Note: See TracTickets for help on using tickets.