Make WordPress Core

Opened 22 months ago

Last modified 2 weeks ago

#56204 new defect (bug)

Twenty Thirteen: Table font size not reflected in editor and Front

Reported by: umesh84's profile umesh84 Owned by:
Milestone: 6.6 Priority: normal
Severity: normal Version: 6.0
Component: Bundled Theme Keywords: has-patch has-testing-info has-screenshots
Focuses: css Cc:

Description

Theme: Twenty Thirteen Table font size not reflected in editor and Front

Steps to replicate:

1: Activate the Twenty Thirteen Theme
2: add Table block
3: Select Size

Attaching a video link for better understanding.
https://www.loom.com/share/b2801ca097754378833c061a051c9597

Attachments (3)

56204.patch (818 bytes) - added by umesh84 22 months ago.
added patch
56204.2.patch (438 bytes) - added by shailu25 4 weeks ago.
Patch Updated
56204.diff (1.3 KB) - added by shailu25 2 weeks ago.
Patch Updated

Download all attachments as: .zip

Change History (12)

@umesh84
22 months ago

added patch

#1 @umesh84
22 months ago

  • Keywords has-patch added; needs-patch removed

#2 @desrosj
22 months ago

  • Summary changed from Theme: Twenty Thirteen Table font size not reflected in editor and Front to Twenty Thirteen: Table font size not reflected in editor and Front

#3 @desrosj
22 months ago

  • Keywords changes-requested added

56204.patch does fix the issue, however it will increase the font size for legacy tables from 14px to 16px. It would be great to find a backwards compatible way to address this.

@shailu25
4 weeks ago

Patch Updated

#4 @shailu25
4 weeks ago

  • Keywords changes-requested removed

With 56204.2.patch​

  • if Font size is not selected then it will show default font size's font.(14px)
  • if Font size is selected in editor, then it will show selected font size's font.

#5 @karmatosed
3 weeks ago

  • Milestone changed from Awaiting Review to 6.6

To me this solves the issue of legacy by keeping the 14px but I am curious what others feel. I do think we have to follow what we did with other themes which is use inherit. I am going to cautiously add a milestone on this and loop back in a few eyes to check our approach so we can catch the default themes that are displaying this issue.

cc @desrosj to make sure meeting your requirement you asked for.

@shailu25
2 weeks ago

Patch Updated

#6 @shailu25
2 weeks ago

Updated Patch Because, I forgot to add editor-blocks.css file's changes in Previous Patch.

#7 @harshgajipara
2 weeks ago

  • Keywords has-testing-info has-screenshots added

Test Report

This report validates that the indicated patch addresses the issue.

Patch tested: https://core.trac.wordpress.org/attachment/ticket/56204/56204.diff

Environment

OS: Windows
PHP: 8.2.12
WordPress: 6.5
Browser: Chrome
Theme: Twenty Thirteen
Plugins: None activated

Actual Results:

✅ Before patch: Table font size not reflected in editor and Front
Backend: https://prnt.sc/7m5aK5bV0Iz6
Frontend: https://prnt.sc/u3VOv10kMpCi

✅ After patch: Table font size reflecting in editor and Front
Backend: https://prnt.sc/wJGKZVwA2aC3
Frontend: https://prnt.sc/TZQ2ZBp69vCE

#8 @darshitrajyaguru97
2 weeks ago

Test Report

Patch tested: https://core.trac.wordpress.org/attachment/ticket/56204/56204.diff

Environment:

OS: Windows
PHP: 8.2.12
WordPress: 6.5
Browser: Chrome
Theme: Twenty Thirteen
Plugins: None activated

Actual Results:

Before patch: Table font size not reflected in editor and Front
Backend: https://prnt.sc/dXY94KllMRE1
Frontend: https://prnt.sc/VS3jNtOZGpQe

After patch: Table font size reflecting in editor and Front
Backend: https://prnt.sc/Mb_-H8GDe88x
Frontend: https://prnt.sc/9tFezQX36PwJ

Patch working well as desired solution

#9 @itpathsolutions
2 weeks ago

Patch tested: https://core.trac.wordpress.org/attachment/ticket/56204/56204.diff

Environment:

OS: Windows
PHP: 8.1.23
WordPress: 6.5
Browser: Chrome
Theme: Twenty Thirteen
Plugins: None activated

Actual Results:

  • Issue Resolved With Patch. ✅ (Table font size reflecting frontend & backend both side.)

Screenshot:

Backend:
Before Patch: https://prnt.sc/-z_8eVRiuMCa
After Patch : https://prnt.sc/69sYSJfEZsjh

Frontend:
Before Patch: https://prnt.sc/LYDTdb5tkeCu
After Patch: https://prnt.sc/BxfjWiBGW42R

Last edited 2 weeks ago by itpathsolutions (previous) (diff)
Note: See TracTickets for help on using tickets.