Twenty Thirteen: Table font size not reflected in editor and Front

[umesh84]

Theme: Twenty Thirteen Table font size not reflected in editor and Front

Steps to replicate:

1: Activate the Twenty Thirteen Theme
2: add Table block
3: Select Size

Attaching a video link for better understanding.
​https://www.loom.com/share/b2801ca097754378833c061a051c9597

[umesh84]

added patch

[desrosj]

56204.patch​ does fix the issue, however it will increase the font size for legacy tables from 14px to 16px. It would be great to find a backwards compatible way to address this.

[shailu25]

Patch Updated

[shailu25]

With 56204.2.patch​

• if Font size is not selected then it will show default font size's font.(14px)
• if Font size is selected in editor, then it will show selected font size's font.

[karmatosed]

To me this solves the issue of legacy by keeping the 14px but I am curious what others feel. I do think we have to follow what we did with other themes which is use inherit. I am going to cautiously add a milestone on this and loop back in a few eyes to check our approach so we can catch the default themes that are displaying this issue.

cc @desrosj to make sure meeting your requirement you asked for.

[shailu25]

Patch Updated

[shailu25]

Updated Patch Because, I forgot to add editor-blocks.css file's changes in Previous Patch.

[harshgajipara]

Test Report

This report validates that the indicated patch addresses the issue.

Patch tested: https://core.trac.wordpress.org/attachment/ticket/56204/56204.diff

Environment

OS: Windows
PHP: 8.2.12
WordPress: 6.5
Browser: Chrome
Theme: Twenty Thirteen
Plugins: None activated

Actual Results:

✅ Before patch: Table font size not reflected in editor and Front
Backend: ​https://prnt.sc/7m5aK5bV0Iz6
Frontend: ​https://prnt.sc/u3VOv10kMpCi

✅ After patch: Table font size reflecting in editor and Front
Backend: ​https://prnt.sc/wJGKZVwA2aC3
Frontend: ​https://prnt.sc/TZQ2ZBp69vCE

[darshitrajyaguru97]

Test Report

Patch tested: https://core.trac.wordpress.org/attachment/ticket/56204/56204.diff

Environment:

OS: Windows
PHP: 8.2.12
WordPress: 6.5
Browser: Chrome
Theme: Twenty Thirteen
Plugins: None activated

Actual Results:

✅ Before patch: Table font size not reflected in editor and Front
Backend: ​https://prnt.sc/dXY94KllMRE1
Frontend: ​https://prnt.sc/VS3jNtOZGpQe

✅ After patch: Table font size reflecting in editor and Front
Backend: ​https://prnt.sc/Mb_-H8GDe88x
Frontend: ​https://prnt.sc/9tFezQX36PwJ

Patch working well as desired solution

[itpathsolutions]

Patch tested: https://core.trac.wordpress.org/attachment/ticket/56204/56204.diff

Environment:

OS: Windows
PHP: 8.1.23
WordPress: 6.5
Browser: Chrome
Theme: Twenty Thirteen
Plugins: None activated

Actual Results:

• Issue Resolved With Patch. ✅ (Table font size reflecting frontend & backend both side.)

Screenshot:

Backend:
Before Patch: ​https://prnt.sc/-z_8eVRiuMCa
After Patch : ​https://prnt.sc/69sYSJfEZsjh

Frontend:
Before Patch: ​https://prnt.sc/LYDTdb5tkeCu
After Patch: ​https://prnt.sc/BxfjWiBGW42R

[karmatosed]

Unless I am mistaken this doesn't offer a default font size which is the preference currently for methods in other blocks. We are using a font size, then inherit to allow for both. This means we get a default. This is an example of where it has worked: https://core.trac.wordpress.org/attachment/ticket/59800/59800.1.diff

Could we perhaps refresh this patch to consider this approach?

[shailu25]

Hi @karmatosed

Thanks for the Feedback.

Table block's Default size is already added in style.css: ​https://github.com/WordPress/wordpress-develop/blob/3d139fdf61ae62b51ac26ad28fd2efd89758f173/src/wp-content/themes/twentythirteen/style.css#L423

In Latest patch, I have Added font-size: inherit; if font size is selected in the editor, else it will show default font-size:14px;

Related: 58704

[karmatosed]

In 58103:

Twenty Thirteen: Updates table font size in editor and front.

The table font size wasn't reflecting in editor and front. What this does is keep the default and adds in an inherit.

Props umesh84, desrosj, shailu25, harshgajipara, darshitrajyaguru97, itpathsolutions.
Fixes #56204.

[karmatosed]

Thank you everyone for the work on this. Committed in the above version.