Opened 3 years ago
Closed 10 months ago
#56205 closed enhancement (wontfix)
Twenty Twenty: background color of column can affect the inner content color
Reported by: |
|
Owned by: | |
---|---|---|---|
Milestone: | Priority: | low | |
Severity: | normal | Version: | 6.0 |
Component: | Bundled Theme | Keywords: | close |
Focuses: | css | Cc: |
Description
Steps to reproduce :-
- Activate Twenty Twenty theme.
- Choose Columns block.
- Give background-colour Accent colour from the options.
- In inner column give a white background.
all the text under that column block is not visible because it is by default taking white colour.
For better understanding please refer to this video.
Video URL:- https://share.cleanshot.com/vskbRyILtP0XkAq8aid4
Attachments (2)
Change History (7)
#1
@
3 years ago
- Summary changed from Twenty Twenty theme background color of column can affect the inner connect color. to Twenty Twenty: background color of column can affect the inner connect color
#2
@
3 years ago
- Focuses css added
- Keywords close 2nd-opinion needs-patch added
- Priority changed from normal to low
- Summary changed from Twenty Twenty: background color of column can affect the inner connect color to Twenty Twenty: background color of column can affect the inner content color
- Type changed from defect (bug) to enhancement
#3
@
3 years ago
hi @nidhidhandhukiya
Can you please check the applied patch, because you updated css in twenty twenty one redirectory.
#4
@
11 months ago
- Keywords close removed
As this has a patch I am going to for now remove the close keyword and focus on getting this tested, thank you everyone.
#5
@
10 months ago
- Keywords close added; 2nd-opinion needs-patch removed
- Milestone Awaiting Review deleted
- Resolution set to wontfix
- Status changed from new to closed
After reviewing this beyond triage I agree with @sabernhardt that closing is the right path for this.
I do not consider this a bug. The default does not work in all situations, but users can correct it themselves. If I add a block with a custom light background inside another block with a darker background, then I need to specify a Text color for the inner block.
This is particularly what I agree with so will add back the close keyword and agree as the 2nd opinion here.
Thanks for the report!
I do not consider this a bug. The default does not work in all situations, but users can correct it themselves. If I add a block with a custom light background inside another block with a darker background, then I need to specify a Text color for the inner block.
If we change the default, that could override user-defined text colors, and it could apply a dark text color when the inner block has a custom dark background. A selector like
:root .has-accent-background-color :where(.has-background:not(.has-text-color))
might prevent creating those problems on existing sites. The new default for inner blocks would involve updating stylesheets for front-end and editor, plus the PHP for custom accent colors.