Make WordPress Core

Opened 20 months ago

Last modified 20 months ago

#56205 new enhancement

Twenty Twenty: background color of column can affect the inner content color

Reported by: nidhidhandhukiya's profile nidhidhandhukiya Owned by:
Milestone: Awaiting Review Priority: low
Severity: normal Version: 6.0
Component: Bundled Theme Keywords: close 2nd-opinion needs-patch
Focuses: css Cc:

Description

Steps to reproduce :-

  1. Activate Twenty Twenty theme.
  2. Choose Columns block.
  3. Give background-colour Accent colour from the options.
  4. In inner column give a white background.

all the text under that column block is not visible because it is by default taking white colour.
For better understanding please refer to this video.
Video URL:- https://share.cleanshot.com/vskbRyILtP0XkAq8aid4

Attachments (2)

56205.patch (1.0 KB) - added by nidhidhandhukiya 20 months ago.
56205.1.patch (1.3 KB) - added by multidots1896 20 months ago.
added patch

Download all attachments as: .zip

Change History (5)

#1 @desrosj
20 months ago

  • Summary changed from Twenty Twenty theme background color of column can affect the inner connect color. to Twenty Twenty: background color of column can affect the inner connect color

#2 @sabernhardt
20 months ago

  • Focuses css added
  • Keywords close 2nd-opinion needs-patch added
  • Priority changed from normal to low
  • Summary changed from Twenty Twenty: background color of column can affect the inner connect color to Twenty Twenty: background color of column can affect the inner content color
  • Type changed from defect (bug) to enhancement

Thanks for the report!

I do not consider this a bug. The default does not work in all situations, but users can correct it themselves. If I add a block with a custom light background inside another block with a darker background, then I need to specify a Text color for the inner block.

If we change the default, that could override user-defined text colors, and it could apply a dark text color when the inner block has a custom dark background. A selector like :root .has-accent-background-color :where(.has-background:not(.has-text-color)) might prevent creating those problems on existing sites. The new default for inner blocks would involve updating stylesheets for front-end and editor, plus the PHP for custom accent colors.

#3 @multidots1896
20 months ago

hi @nidhidhandhukiya
Can you please check the applied patch, because you updated css in twenty twenty one redirectory.

@multidots1896
20 months ago

added patch

Note: See TracTickets for help on using tickets.