Twenty Twenty: background color of column can affect the inner content color

[nidhidhandhukiya]

Steps to reproduce :-

1. Activate Twenty Twenty theme.
2. Choose Columns block.
3. Give background-colour Accent colour from the options.
4. In inner column give a white background.

all the text under that column block is not visible because it is by default taking white colour.
For better understanding please refer to this video.
Video URL:- ​https://share.cleanshot.com/vskbRyILtP0XkAq8aid4

[sabernhardt]

Thanks for the report!

I do not consider this a bug. The default does not work in all situations, but users can correct it themselves. If I add a block with a custom light background inside another block with a darker background, then I need to specify a Text color for the inner block.

If we change the default, that could override user-defined text colors, and it could apply a dark text color when the inner block has a custom dark background. A selector like :root .has-accent-background-color :where(.has-background:not(.has-text-color)) might prevent creating those problems on existing sites. The new default for inner blocks would involve updating stylesheets for front-end and editor, plus the PHP for custom accent colors.

[multidots1896]

hi @nidhidhandhukiya
Can you please check the applied patch, because you updated css in twenty twenty one redirectory.

[multidots1896]

added patch

[karmatosed]

As this has a patch I am going to for now remove the close keyword and focus on getting this tested, thank you everyone.

[karmatosed]

After reviewing this beyond triage I agree with @sabernhardt that closing is the right path for this.

I do not consider this a bug. The default does not work in all situations, but users can correct it themselves. If I add a block with a custom light background inside another block with a darker background, then I need to specify a Text color for the inner block.

This is particularly what I agree with so will add back the close keyword and agree as the 2nd opinion here.