Make WordPress Core

Opened 2 years ago

Closed 22 months ago

Last modified 22 months ago

#56210 closed defect (bug) (fixed)

What's new page design issue in core wordpress

Reported by: weboccults's profile weboccults Owned by: marybaum's profile marybaum
Milestone: 6.0.2 Priority: normal
Severity: normal Version: 6.0
Component: Help/About Keywords: has-patch has-testing-info has-screenshots commit
Focuses: Cc:

Description

Additional design tools boxes are not equal height. please refer screenshot

wp-admin/about.php

https://i.imgur.com/28YwbZ9.jpg

Attachments (1)

56210.diff (1.1 KB) - added by sabernhardt 2 years ago.
making SVG smaller by removing empty space

Download all attachments as: .zip

Change History (13)

#1 @SergeyBiryukov
2 years ago

  • Component changed from General to Help/About

#2 @SergeyBiryukov
2 years ago

  • Version set to 6.0

@sabernhardt
2 years ago

making SVG smaller by removing empty space

#3 @sabernhardt
2 years ago

The circle image is 40 pixels tall, and the rest are 32. The SVG can match that height without changing the dimensions of the 24-pixel circles within.

#4 @sabernhardt
2 years ago

  • Keywords has-patch added; needs-patch removed
  • Milestone changed from Awaiting Review to 6.0.2

This ticket was mentioned in Slack in #core by abhanonstopnews. View the logs.


2 years ago

#6 @webcommsat
2 years ago

Thank you @sabernhardt for reviewing this ticket and setting the milestone to 6.0.2 and to @weboccults for highlighting it and their first ticket.

#7 @ironprogrammer
23 months ago

  • Keywords has-testing-info has-screenshots added

Thank you for the report, @weboccults! Thanks to @sabernhardt for the fix as well 👍🏻

Test Report

This report validates that the indicated patch addresses the issue. LGTM!

Patch tested: https://core.trac.wordpress.org/attachment/ticket/56210/56210.diff

Steps to Reproduce

  1. Navigate to /wp-admin/about.php and scroll to the "Additional Design Tools" section.
  2. 🐞 Observe the vertical misalignment of the 3rd column of text (Figure 1).

Expected Results

After applying the patch:

  • ✅ The vertical alignment of the 3rd column of text is corrected.

Environment

  • OS: macOS 12.5
  • Browser: Safari 15.6
  • Server: nginx/1.23.1
  • PHP: 7.4.30
  • WordPress: 6.0.2-alpha-53697-src

Actual Results

  • ✅ Issue resolved with patch (Figure 2).

Supplemental Artifacts

Figure 1: Before patch (refer to horizontal reference line and vertical text alignment)
https://cldup.com/cwJ736xfTG.thumb.jpg

Figure 2: After patch
https://cldup.com/XhMrFRAYft.thumb.jpg

#8 @marybaum
22 months ago

  • Keywords commit added
  • Owner set to marybaum
  • Status changed from new to assigned

In an ideal world I would change Additional Desigh Tools to More Design Tools, but this needs to commit today for tomorrow’s RC, so I can live with it for now.

The copy blocks are balanced and aligned, so we’re good to go!

#9 @marybaum
22 months ago

Props @webcommsat @oglekler for moving this ticket along at today’s component scrub!

#10 @SergeyBiryukov
22 months ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 53924:

Help/About: Improve vertical alignment in the Additional Design Tools section.

This makes a transparent circle SVG smaller by removing empty space to match the height of other images in the same section, so that all three columns are aligned correctly.

Follow-up to [53339].

Props sabernhardt, weboccults, ironprogrammer, webcommsat, marybaum, oglekler.
Fixes #56210.

#11 @SergeyBiryukov
22 months ago

In 53925:

Help/About: Improve vertical alignment in the Additional Design Tools section.

This makes a transparent circle SVG smaller by removing empty space to match the height of other images in the same section, so that all three columns are aligned correctly.

Follow-up to [53339].

Props sabernhardt, weboccults, ironprogrammer, webcommsat, marybaum, oglekler.
Merges [53924] to the 6.0 branch.
Fixes #56210.

This ticket was mentioned in Slack in #core by costdev. View the logs.


22 months ago

Note: See TracTickets for help on using tickets.