Further remove code from translatable strings in wp-includes/ms-default-constants.php

[SergeyBiryukov]

Background: #35994.

[36773] removed some code from a translatable string in wp-includes/ms-default-constants.php, specifically constant names, file name, and a function name, as these names don't need translation.

However, there is one more string directly below which still includes some constant names:

trigger_error( __( '<strong>Conflicting values for the constants VHOST and SUBDOMAIN_INSTALL.</strong> The value of SUBDOMAIN_INSTALL will be assumed to be your subdomain configuration setting.' ) . ' ' . $vhost_deprecated, E_USER_WARNING );

As VHOST or SUBDOMAIN_INSTALL don't need translation, this can be replaced with:

trigger_error(
	sprintf(
		/* translators: 1: VHOST, 2: SUBDOMAIN_INSTALL */
		__( '<strong>Conflicting values for the constants %1$s and %2$s.</strong> The value of %2$s will be assumed to be your subdomain configuration setting.' ),
		'<code>VHOST</code>',
		'<code>SUBDOMAIN_INSTALL</code>'
	) . ' ' . $vhost_deprecated,
	E_USER_WARNING
);

[weboccults]

Patch created with suggested edits

[hztyfoon]

added this patch 56216.1.patch as looks like in 56216.diff there's the line /* translators: 1: VHOST, 2: SUBDOMAIN_INSTALL */ added twice.

Created pull request for correct translation text suggested in issue.

https://core.trac.wordpress.org/ticket/56216

[SergeyBiryukov]

Looks good, thanks everyone!

[SergeyBiryukov]

In 53699:

I18N: Remove code from a translatable string in wp-includes/ms-default-constants.php.

This replaces the VHOST and SUBDOMAIN_INSTALL constant names in a message in ms_subdomain_constants() with placeholders, as they don't need to be translated.

Follow-up to [36773].

Props weboccults, hztyfoon, pratiweb.
Fixes #56216.

Thanks for the PR! Merged in r53699.