WordPress.org
Get WordPress

Make WordPress Core

Changes between Version 1 and Version 2 of Ticket #56219, comment 5


Ignore:
Timestamp:
07/15/2022 12:57:28 PM (2 years ago)
Author:
SergeyBiryukov
Comment:

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #56219, comment 5

    v1 v2  
    11@antonvlasenko Couple of points here:
    22
    3 1. The changes you are suggesting are for an external dependency. That dependency has already released a version compatible with PHP 8.1 (and 8.2 for that matter). WP just hasn't upgraded yet. See: https://core.trac.wordpress.org/ticket/54504
     31. The changes you are suggesting are for an external dependency. That dependency has already released a version compatible with PHP 8.1 (and 8.2 for that matter). WP just hasn't upgraded yet. See: #54504.
    442. The only reason the Importer plugin has a PHPUnit restriction is because it is needed to support older WP versions. With WP 5.9 or higher, all necessary PHPUnit versions are supported. You should NOT run with `--ignore-platform-reqs`. Instead you should run `composer remove --dev phpunit/phpunit` (this will not actually remove phpunit, but will remove the version restriction). See: https://github.com/WordPress/wordpress-importer/blob/c0e188a85c57fadde914e397bd4b0a9c104e5f17/.github/workflows/test.yml#L108-L146 for the full details and explanation.
    55