WordPress.org

Make WordPress Core

Opened 6 years ago

Closed 5 years ago

#5623 closed enhancement (invalid)

Reduce logic structure with better regex in wp-settings.php

Reported by: sambauers Owned by:
Milestone: Priority: lowest
Severity: trivial Version: 2.5
Component: Optimization Keywords: regex has-patch needs-testing needs-unittests
Focuses: Cc:

Description

The attached patch reduces some logic in wp-settings by using slightly more efficient regex in one of the cases.

Low priority as this logic is only called during installation.

Attachments (1)

one_less_regex.diff (866 bytes) - added by sambauers 6 years ago.

Download all attachments as: .zip

Change History (5)

sambauers6 years ago

comment:1 hansengel6 years ago

  • Keywords has-patch needs-testing added

comment:2 lloydbudd6 years ago

  • Milestone changed from 2.5 to 2.6

comment:3 jacobsantos5 years ago

  • Keywords needs-unittests added

Needs unit tests.

comment:4 Denis-de-Bernardy5 years ago

  • Milestone 2.9 deleted
  • Resolution set to invalid
  • Status changed from new to closed

semantics between the two regex are different

one will catch wp-admin. the other will only catch wp-admin/.

Note: See TracTickets for help on using tickets.