Make WordPress Core

Opened 23 months ago

Closed 22 months ago

Last modified 20 months ago

#56230 closed defect (bug) (fixed)

Incorrect aria-live announcement when removing a permalink custom structure

Reported by: joedolson's profile joedolson Owned by: joedolson's profile joedolson
Milestone: 6.1 Priority: normal
Severity: normal Version: 4.9
Component: Permalinks Keywords: has-patch commit add-to-field-guide
Focuses: accessibility, javascript Cc:

Description (last modified by sabernhardt)

When removing an added custom structure at Settings > Permalinks, the same message is announced as when adding the custom structure, e.g. "year added to permalink structure". The message when removing should instead indicate "year removed from permalink structure".

The button's aria-label is changed to indicate that the element is already used, and that changes after activating the link, but the announced message will give the impression that you have added the structure rather than removing.

This was introduced in changeset:41182.

Attachments (3)

56230.diff (1.8 KB) - added by joedolson 23 months ago.
Add 'remove' message to permalink structure buttons
56230.2.diff (2.2 KB) - added by SergeyBiryukov 23 months ago.
56230.3.diff (2.0 KB) - added by joedolson 22 months ago.
Move setting textToAnnounce back to before it's announced.

Download all attachments as: .zip

Change History (13)

@joedolson
23 months ago

Add 'remove' message to permalink structure buttons

#1 @joedolson
23 months ago

  • Keywords has-patch needs-testing added; needs-patch removed

#2 @joedolson
23 months ago

Tested with NVDA/Chrome already.

Testing:

  • at Settings > Permalinks, using a screen reader, navigate to custom structure buttons.
  • Add a structure to the permalink format, noting announcement '{tag} added to permalink structure'
  • Navigate back to same structure, click again to remove. note announcement '{tag} removed from permalink structure'.

#3 @sabernhardt
23 months ago

  • Description modified (diff)

#4 @kebbet
23 months ago

  • Keywords needs-refresh added

Might need a refresh after all updates to options-permalink.php.

#5 @SergeyBiryukov
23 months ago

  • Keywords needs-refresh removed

Refreshed after [53710].

This ticket was mentioned in Slack in #accessibility by ryokuhi. View the logs.


22 months ago

@joedolson
22 months ago

Move setting textToAnnounce back to before it's announced.

#7 @joedolson
22 months ago

  • Keywords commit added; needs-testing removed

Updated patch & tested with VoiceOver/Safari & JAWS/Firefox. Marking for commit.

#8 @joedolson
22 months ago

  • Owner set to joedolson
  • Status changed from new to accepted

#9 @joedolson
22 months ago

  • Resolution set to fixed
  • Status changed from accepted to closed

In 53911:

Permalinks: Fix aria-live text when removing custom structure.

Change the notification announced when a custom structure is removed. Previously, the notification incorrectly indicated that the structure was added for both actions. This changes the notification to correctly announce removals when structures are removed.

Props joedolson, kebbet, SergeyBiryukov.
Fixes #56230.

#10 @milana_cap
20 months ago

  • Keywords add-to-field-guide added
Note: See TracTickets for help on using tickets.