WordPress.org
Get WordPress

Make WordPress Core

Opened 3 years ago

Closed 2 years ago

#56233 closed defect (bug) (fixed)

Dead link and/or obsolete function description in `addslashes_gpc()`

Reported by: audrasjb's profile audrasjb Owned by: audrasjb's profile audrasjb
Milestone: 6.1 Priority: normal
Severity: normal Version: 2.7
Component: Formatting Keywords: has-patch
Focuses: docs Cc:

Description

@mitweka reported on DevHub User notes that function ​addslashes_gpc has a dead link to ​https://www.php.net/magic_quotes in the function description.

Given magic_quotes is not used anymore in WP Core and after having a look to ticket:40716#comment:1, I guess we can probably remove entirely this obsolete function description. Thoughts?

Change History (10)

This ticket was mentioned in ​PR #2984 on ​WordPress/wordpress-develop by ​audrasjb.
3 years ago #1

  • Keywords has-patch added

Trac ticket: https://core.trac.wordpress.org/ticket/56233

#2 @audrasjb
3 years ago

  • Focuses docs added
  • Keywords 2nd-opinion added

#3 @audrasjb
2 years ago

  • Milestone changed from Awaiting Review to 6.1

Moving for 6.1 consideration.

#4 @audrasjb
2 years ago

  • Version set to 0.71

#5 in reply to: ↑ description @SergeyBiryukov
2 years ago

Replying to audrasjb:

Given magic_quotes is not used anymore in WP Core and after having a look to ticket:40716#comment:1, I guess we can probably remove entirely this obsolete function description.

Yes, I agree:

  • Usage of get_magic_quotes_gpc() was removed from addslashes_gpc() in [46105] / #47783.
  • A similar description fragment was removed from wp_parse_str() in that changeset, but this one was missed.
  • The ​get_magic_quotes_gpc() function itself was deprecated in PHP 7.4 and removed in PHP 8.0.

#6 @SergeyBiryukov
2 years ago

  • Version changed from 0.71 to 2.7

Introduced in [8743] / #5638.

#7 @audrasjb
2 years ago

Thanks for the review :-)
Self assigning for commit.

#8 @audrasjb
2 years ago

  • Owner set to audrasjb
  • Status changed from new to accepted

#9 @audrasjb
2 years ago

  • Keywords 2nd-opinion removed

#10 @audrasjb
2 years ago

  • Resolution set to fixed
  • Status changed from accepted to closed

In 53776:

Docs: Remove an obsolete function description in addslashes_gpc().

  • Usage of get_magic_quotes_gpc() was removed from addslashes_gpc() in [46105] / #47783.
  • A similar description fragment was removed from wp_parse_str() in that changeset, but this one was missed.
  • The get_magic_quotes_gpc() function itself was deprecated in PHP 7.4 and removed in PHP 8.0.

Props mitweka, audrasjb, SergeyBiryukov.
Fixes #56233.
See #55646.

Note: See TracTickets for help on using tickets.