WordPress.org
Get WordPress

Make WordPress Core

Opened 4 years ago

Closed 4 years ago

#56235 closed enhancement (fixed)

Use a variable for home URL on Permalink Settings screen

Reported by: sabernhardt Owned by: SergeyBiryukov
Priority: normal Milestone: 6.1
Component: Permalinks Version:
Severity: normal Keywords: has-patch
Cc: Focuses: administration

Description

As noted on #56110, I think replacing several instances of get_option( 'home' ) with a variable could improve the code.

It could also use the home_url() function, with escaping.

$url_base = esc_url( home_url() );

Attachments (2)

56235.diff​ (4.4 KB ) - added by sabernhardt 4 years ago.
56235.2.diff​ (681 bytes ) - added by SergeyBiryukov 4 years ago.

Download all attachments as: .zip

Change History (5)

@sabernhardt
4 years ago

#1 @SergeyBiryukov
4 years ago

  • Milestone Awaiting Review → 6.1

I ended up refactoring the whole file in [53710] / #55647 and only saw this ticket after committing. Sorry for that!

We could still use this ticket to replace get_option( 'home' ) with home_url().

@SergeyBiryukov
4 years ago

#2 @SergeyBiryukov
4 years ago

It looks like esc_url() might not be needed here, as the value is not used in an href or src tag. However, home_url() does appear to be a more common way of retrieving the home URL across the admin.

#3 @SergeyBiryukov
4 years ago

  • Owner set to SergeyBiryukov
  • Resolution → fixed
  • Status new → closed

In 53712:

Permalinks: Use home_url() to set the URL base on Permalink Settings screen.

This brings more consistency with how the home URL is retrieved elsewhere in the admin.

Follow-up to [1567], [1664], [2746], [3029], [4144], [53710].

Props sabernhardt.
Fixes #56235.

Note: See TracTickets for help on using tickets.