#56283 closed feature request (fixed)
Add "Block Theme" filter under "Add themes"
Reported by: |
|
Owned by: |
|
---|---|---|---|
Milestone: | 6.1 | Priority: | normal |
Severity: | major | Version: | |
Component: | Themes | Keywords: | has-patch has-screenshots needs-docs needs-user-docs needs-dev-note |
Focuses: | ui, accessibility, administration | Cc: |
Description
The Theme Directory on wordpress.org recently got updated to show a shortcut for filtering block themes: https://meta.trac.wordpress.org/ticket/6330
Let's add that shortcut to the filter bar when adding a new theme from the WordPress backend. See attachment screenshot for a suggestion.
Attachments (3)
Change History (27)
This ticket was mentioned in PR #3019 on WordPress/wordpress-develop by audrasjb.
17 months ago
#3
- Keywords has-patch added
Trac ticket: https://core.trac.wordpress.org/ticket/56283
#4
@
17 months ago
- Focuses accessibility added
- Keywords dev-feedback needs-testing has-screenshots needs-docs needs-user-docs needs-dev-note added
- Type changed from enhancement to feature request
- Version trunk deleted
The above PR is a first workaround for this feature.
I'm not a specialist of the Appearance screen, so this changeset needs to be fully tested. I'm also adding the accessibility
focus since I'm not sure my JS change is enough to trigger all the small accessibility features triggered by a "normal" tag search on this screen.
#5
@
17 months ago
The changes in the PR don't work for me, I think the JS part is correct but put in the wrong function. I've made it working by moving it to the browse
function, starting on line 1693:
// Handles all the rendering of the public theme directory. browse: function( section ) { // Create a new collection with the proper theme data // for each section. if ( 'block-themes' === section ) { var request = { tag: 'full-site-editing' }; // Get the themes by sending Ajax POST request to api.wordpress.org/themes // or searching the local cache. this.collection.query( request ); } else { this.collection.query( { browse: section } ); } },
With this change, I get properly working results. @audrasjb Do you want to give this snippet a test?
#6
@
17 months ago
Could we put "Block Themes" between "Latest" and "Favorites", same as in the Theme Directory?
#8
@
17 months ago
@audrasjb I've left a review comment on the PR as it's not working for me atm, I think the changes I suggested should make it work :)
#11
@
17 months ago
- Keywords needs-testing needs-dev-note removed
- Owner set to audrasjb
- Status changed from new to accepted
Removing the needs-dev-note
workflow keyword as it is not really a technical change, no new filter is available. But we should of course update the end-user docs on HelpHub.
I think we're good to go with this. Let's discuss this change during the next devchat, because I want to make sure this discussed within the Core team before it's committed :)
Ping @marybaum ☝️
#13
@
16 months ago
Documentation pages where screenshots/videos of the filter bar are used, for documentation reference:
https://wordpress.org/support/article/using-themes/
https://wordpress.org/support/article/appearance-themes-screen/
This ticket was mentioned in Slack in #core by audrasjb. View the logs.
16 months ago
This ticket was mentioned in Slack in #accessibility by ryokuhi. View the logs.
16 months ago
16 months ago
#19
Committed in https://core.trac.wordpress.org/changeset/53906
#21
@
16 months ago
- Resolution fixed deleted
- Status changed from closed to reopened
Thanks for the commit!
Minor thing, but I think it would read more natural to include a hyphen here, see 56283.2.diff.
That means the filters would include a mix of underscores and a hyphen, which is not quite typical for core, but has a precedent in a similar filter for plugins:
install_plugins_pre_plugin-information
install_plugins_plugin-information
Screenshot of the "Add Themes" page in the WordPress backend. In the Filter Bar, a new link "Block Themes" is added between "Favourites" and "Feature Filter".