Theme JSON: Fix notice when unknown elements are specified

[scruffian]

If a theme.json file specifies an unknown element then we'll get a notice from line 1482 in this file. This adds an array_key_exists check before we get the value of the array at that key, to avoid the notice.

Gutenberg issue: WordPress/gutenberg#42649
GitHub PR: ​https://github.com/WordPress/wordpress-develop/pull/3026

If a theme.json file specifies an unknown element then we'll get a notice from line 1482 in this file. This adds an array_key_exists check before we get the value of the array at that key, to avoid the notice.

Gutenberg issue: ​https://github.com/WordPress/gutenberg/issues/42649
Trac issue: https://core.trac.wordpress.org/ticket/56291

[rudlinkon]

@scruffian thanks for your PR. I checked it yesterday and it looks good to me.

[audrasjb]

@rudlinkon this PR was opened 27 minutes ago :)
Could you please share some reproductions steps to help others to test it as well?

[hztyfoon]

No, the PR was created yesterday @audrasjb 🙂
I also reviewed it.

[audrasjb]

Reviewing is cool, but could you please also share your steps to reproduce the issue and to test the patch? Thanks 🙂

[audrasjb]

I added some unknown elements in TT2 theme.json file and I don't have any warning on my side.

(I of course have the WP_DEBUG constant set to true)

[hztyfoon]

Thanks @audrasjb,

Ok, here's the Step-by-step reproduction instructions (created by @ndiego): ​https://github.com/WordPress/gutenberg/issues/42649#issue-1315463508

I tested it myself with gutenberg 13.7 & found the issue as created by @ndiego.
And also tested the PR's fix & it solved the issue.

[rudlinkon]

@audrasjb here is the instruction ​https://github.com/WordPress/gutenberg/issues/42649 could you please follow this instruction?

[audrasjb]

OK so testing this issue requires to install gutenberg plugin, version 13.7.
Thanks for this important info, it was clearly missing here.

[audrasjb]

Introduced in [50973] (WP 5.8).

[hztyfoon]

hey @scruffian ,

I think U tried to mention the gutenberg link (​https://github.com/WordPress/gutenberg/issues/42649) which I shared in my last comment.
Instead U ended up mentioning another unrelated trac ticket.

No worries, this thing happens.
Can U update the description and correct the gutenebrg issue link there? @scruffian

[hztyfoon]

Sorry @scruffian,
May be U cannot edit the description of the ticket But You can reply the description with quoting the gutenberg issue line.

Like this:
Replying to scruffian:

Gutenberg issue: WordPress/gutenberg#42649

the gutenebrg issue link is this: ​https://github.com/WordPress/gutenberg/issues/42649

Can U please confirm that the link I just mentioned in the reply is the correct one? @scruffian 🙂

[scruffian]

Yeah, sorry I used a shortcode by mistake. The link should be ​https://github.com/WordPress/gutenberg/issues/42649

[audrasjb]

Hello,

This appears to be fixed upstream in Gutenberg. As it should probably be backported with other Gutenberg changes, we'll probably close this ticket as fixed.
For the moment, let's keep it open to track the issue.

This was solved in a different way

[audrasjb]

Fixed upstream on Gutenberg's side.