Make WordPress Core

Changes between Initial Version and Version 11 of Ticket #56293


Ignore:
Timestamp:
07/27/2022 03:14:22 PM (17 months ago)
Author:
SergeyBiryukov
Comment:

Thanks everyone!

// Three seconds, plus one extra second for every 10 themes.
$timeout = MINUTE_IN_SECONDS / 20 + (int) ( count( $themes ) / 10 )

I think MINUTE_IN_SECONDS / 20 is also too complicated :) Keeping that as is, especially with the "Three seconds" comment above, seems more readable to me:

// Three seconds, plus one extra second for every 10 themes.
$timeout = 3 + (int) ( count( $themes ) / 10 );

Same goes for this:

'timeout'    => $doing_cron ? MINUTE_IN_SECONDS / 2 : MINUTE_IN_SECONDS / 20,

This might be more readable:

// Half a minute when doing cron tasks, 3 seconds otherwise.
'timeout'    => $doing_cron ? MINUTE_IN_SECONDS / 2 : 3,

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #56293

    • Property Keywords has-patch changes-requested added
    • Property Owner set to audrasjb
    • Property Status changed from new to reviewing
    • Property Milestone changed from Awaiting Review to 6.1
  • Ticket #56293 – Description

    initial v11  
    33$timeout = 30;
    44}}}
    5 I think It should be like this (MINUTE_IN_SECONDS also used multiple time in this file) as done here in this commit #53714:
     5I think It should be like this (MINUTE_IN_SECONDS also used multiple time in this file) as done here in this commit [53714]:
    66
    77{{{