#56297 closed defect (bug) (fixed)
Twenty Eleven: asterisk symbol alignment with WooCommerce reviews rating label
| Reported by: | umesh84 | Owned by: | audrasjb |
|---|---|---|---|
| Priority: | normal | Milestone: | 6.1 |
| Component: | Bundled Theme | Version: | 5.9 |
| Severity: | normal | Keywords: | has-screenshots has-patch has-test-info commit |
| Cc: | Focuses: | css |
Description
When we open a single product page Theme Twenty Eleven in the review tab asterisk symbol alignment not proper.
1: Go to Theme Twenty Eleven
2: Download woocommerce plugin
3: Active woocommerce plugin
4: Add Product
5: Go single product page
Attachments (3)
Change History (12)
#2
@
4 years ago
- Focuses ui removed
- Summary Theme Twenty Eleven in the review tab asterisk symbol alignment not proper → Twenty Eleven: asterisk symbol alignment with WooCommerce reviews rating label
- Version 6.0 → 5.9
r52152 added the float, intending it for labels positioned in front of their fields.
The selectors may need to be stricter, listing each field that has the special styling:
#respond .comment-form-author label .required,
#respond .comment-form-email label .required,
#respond .comment-form-url label .required,
#respond .comment-form-comment label .required {
float: right;
margin-left: 4px;
}
@
4 years ago
targeting the .required span for 4 specific fields, removing remnant of absolute positioning
#3
@
4 years ago
- Milestone Awaiting Review → 6.1
56297.1.diff includes the URL field label, in case someone makes that required.
Also, I had missed removing the left and right value adjustments at the 650px breakpoint on ticket:54408.
#4
@
4 years ago
- Keywords has-testing-info commit added
Test Report
Patch tested: 56297.1.diff
Steps to Reproduce or Test
- Navigate to
Appearance > Themes - Activate the
Twenty Eleventheme. - Navigate to
Plugins > Add New. - Install and activate
WooCommerce. - Navigate to
Products > Add New. - Enter a name and publish the product.
- View the product on the frontend.
- 🐞 The asterisk that should be beside
Your ratingis at the opposite side of the container. - Apply 56297.1.diff.
- Rebuild the CSS files.
- Refresh the product page on the frontend. (might need a hard refresh using
Ctrl+F5orCmd+R).
Expected Results
- 🐞❌ Before the patch: The asterisk is not beside
Your rating. - ✅ After the patch: The asterisk is beside
Your rating.
Environment
- Server: Apache (Linux)
- WordPress: 6.1-alpha-53344-src
- Browser: Chrome 103.0.0.0
- OS: Windows 10
- Theme: Twenty Eleven
- Plugins:
- WooCommerce 6.7.0
Actual Results
- 🐞❌ Issue reproduced: The asterisk is not beside
Your rating. - ✅ Patch 56297.1.diff fixes the issue: The asterisk is beside
Your rating. - ✅ Tested on LTR and RTL.
- ✅ Tested across mobile, tablet, medium and large desktop breakpoints.
Notes
- I think 56297.1.diff is ready for
commitconsideration. Adding the keyword.
#5
@
4 years ago
- Owner set to
- Status new → reviewing
Self assigning for final testing/review and commit.
For better understanding I have attached a screenshot