Deprecated sql functions in the wp-db.php file

[hilayt24]

/Users/smitrathod/local sites/wp-testing-site/app/public/wp-includes/wp-db.php	896	31	error	Extension 'mysql_' is deprecated since PHP 5.5 and removed since PHP 7.0; Use mysqli instead
/Users/smitrathod/local sites/wp-testing-site/app/public/wp-includes/wp-db.php	903	6	error	Extension 'mysql_' is deprecated since PHP 5.5 and removed since PHP 7.0; Use mysqli instead
/Users/smitrathod/local sites/wp-testing-site/app/public/wp-includes/wp-db.php	923	12	error	Extension 'mysql_' is deprecated since PHP 5.5 and removed since PHP 7.0; Use mysqli instead
/Users/smitrathod/local sites/wp-testing-site/app/public/wp-includes/wp-db.php	937	18	error	Extension 'mysql_' is deprecated since PHP 5.5 and removed since PHP 7.0; Use mysqli instead
/Users/smitrathod/local sites/wp-testing-site/app/public/wp-includes/wp-db.php	969	4	error	Extension 'mysql_' is deprecated since PHP 5.5 and removed since PHP 7.0; Use mysqli instead
/Users/smitrathod/local sites/wp-testing-site/app/public/wp-includes/wp-db.php	1178	15	error	Extension 'mysql_' is deprecated since PHP 5.5 and removed since PHP 7.0; Use mysqli instead
/Users/smitrathod/local sites/wp-testing-site/app/public/wp-includes/wp-db.php	1262	16	error	Extension 'mysql_' is deprecated since PHP 5.5 and removed since PHP 7.0; Use mysqli instead
/Users/smitrathod/local sites/wp-testing-site/app/public/wp-includes/wp-db.php	1559	12	error	Extension 'mysql_' is deprecated since PHP 5.5 and removed since PHP 7.0; Use mysqli instead
/Users/smitrathod/local sites/wp-testing-site/app/public/wp-includes/wp-db.php	1698	4	error	Extension 'mysql_' is deprecated since PHP 5.5 and removed since PHP 7.0; Use mysqli instead
/Users/smitrathod/local sites/wp-testing-site/app/public/wp-includes/wp-db.php	1785	18	error	Extension 'mysql_' is deprecated since PHP 5.5 and removed since PHP 7.0; Use mysqli instead
/Users/smitrathod/local sites/wp-testing-site/app/public/wp-includes/wp-db.php	1788	19	error	Extension 'mysql_' is deprecated since PHP 5.5 and removed since PHP 7.0; Use mysqli instead
/Users/smitrathod/local sites/wp-testing-site/app/public/wp-includes/wp-db.php	1924	34	error	Extension 'mysql_' is deprecated since PHP 5.5 and removed since PHP 7.0; Use mysqli instead
/Users/smitrathod/local sites/wp-testing-site/app/public/wp-includes/wp-db.php	2073	21	error	Extension 'mysql_' is deprecated since PHP 5.5 and removed since PHP 7.0; Use mysqli instead
/Users/smitrathod/local sites/wp-testing-site/app/public/wp-includes/wp-db.php	2098	25	error	Extension 'mysql_' is deprecated since PHP 5.5 and removed since PHP 7.0; Use mysqli instead
/Users/smitrathod/local sites/wp-testing-site/app/public/wp-includes/wp-db.php	2120	28	error	Extension 'mysql_' is deprecated since PHP 5.5 and removed since PHP 7.0; Use mysqli instead
/Users/smitrathod/local sites/wp-testing-site/app/public/wp-includes/wp-db.php	2127	25	error	Extension 'mysql_' is deprecated since PHP 5.5 and removed since PHP 7.0; Use mysqli instead
/Users/smitrathod/local sites/wp-testing-site/app/public/wp-includes/wp-db.php	2140	20	error	Extension 'mysql_' is deprecated since PHP 5.5 and removed since PHP 7.0; Use mysqli instead
/Users/smitrathod/local sites/wp-testing-site/app/public/wp-includes/wp-db.php	2171	20	error	Extension 'mysql_' is deprecated since PHP 5.5 and removed since PHP 7.0; Use mysqli instead
/Users/smitrathod/local sites/wp-testing-site/app/public/wp-includes/wp-db.php	3335	30	error	Extension 'mysql_' is deprecated since PHP 5.5 and removed since PHP 7.0; Use mysqli instead
/Users/smitrathod/local sites/wp-testing-site/app/public/wp-includes/wp-db.php	3552	18	error	Extension 'mysql_' is deprecated since PHP 5.5 and removed since PHP 7.0; Use mysqli instead
/Users/smitrathod/local sites/wp-testing-site/app/public/wp-includes/wp-db.php	3554	29	error	Extension 'mysql_' is deprecated since PHP 5.5 and removed since PHP 7.0; Use mysqli instead
/Users/smitrathod/local sites/wp-testing-site/app/public/wp-includes/wp-db.php	3636	15	error	Extension 'mysql_' is deprecated since PHP 5.5 and removed since PHP 7.0; Use mysqli instead
/Users/smitrathod/local sites/wp-testing-site/app/public/wp-includes/wp-db.php	3638	15	error	Extension 'mysql_' is deprecated since PHP 5.5 and removed since PHP 7.0; Use mysqli instead
/Users/smitrathod/local sites/wp-testing-site/app/public/wp-includes/wp-db.php	3674	14	error	Extension 'mysql_' is deprecated since PHP 5.5 and removed since PHP 7.0; Use mysqli instead
/Users/smitrathod/local sites/wp-testing-site/app/public/wp-includes/wp-db.php	3771	24	error	Extension 'mysql_' is deprecated since PHP 5.5 and removed since PHP 7.0; Use mysqli instead
/Users/smitrathod/local sites/wp-testing-site/app/public/wp-includes/wp-db.php	3824	19	error	Extension 'mysql_' is deprecated since PHP 5.5 and removed since PHP 7.0; Use mysqli instead

[hilayt24]

On reviewing the code I found that it was intentional as the condition for the MySQL is checked already. But its better to add the PHPCS:ignore so that the sniffer will skip that [art.

[SergeyBiryukov]

Hi there, thanks for the ticket!

Replying to hilayt24:

On reviewing the code I found that it was intentional as the condition for the MySQL is checked already. But its better to add the PHPCS:ignore so that the sniffer will skip that part.

This is already addressed in the WordPress' PHPCS configuration file, see lines 166-170​. Could you clarify how you run the PHPCS checks?

[jrf]

These errors are coming from PHPCompatibility, which is clearly not run in the recommended manner.

The PHPCS configuration which is applicable for this already explicitly excludes these issues:
​https://github.com/WordPress/wordpress-develop/blob/0a126fd465abaea28b629681fb78cd6dac8874a8/phpcompat.xml.dist#L86-L88