Undefined variable phpcs error for $new_size_meta

[mehulkaklotar]

There is a undefined variable added in the code which is not defined in the context and actual variable should be $created_size_meta in src/wp-admin/includes/image.php line no 634

Trac ticket: https://core.trac.wordpress.org/ticket/56323

[desrosj]

Thanks for this one, @mehulkaklotar!

It looks like this was introduced in [53751] as part of #55443.

It does indeed seem that this variable will not be set here. But I'd like to confirm the intention here with those that worked on this change. @adamsilverstein and @flixos90, are you able to take a look?

It would also be great to add a unit test or two to catch this in the future.

[adamsilverstein]

Thanks for opening this @mehulkaklotar - I'll take a look!

[adamsilverstein]

Good catch @mehulkaklotar! We missed this because it is only happening when make_subsize is unavailable and the system falls back to $editor->multi_resize(). I'm curious how you encountered this bug, were you using a custom image editor class?

[mehulkaklotar]

Yes, @adamsilverstein actually I saw this error first in my PHPCS run. And then when I was testing the generation, got it error in debug.log.

[adamsilverstein]

Yes, @adamsilverstein actually I saw this error first in my PHPCS run

Somehow missed this on my end, thanks for catching.

[adamsilverstein]

56323.diff​ is the fix from the ​PR from @mehulkaklotar

[adamsilverstein]

@mehulkaklotar - fix looks good, a nice improvement would be improved test coverage that fails before the fix - clearly our test coverage isn't complete here.

Fixed in https://core.trac.wordpress.org/changeset/53847

[johnregan3]

@adamsilverstein I'm working on writing tests for this, but I need to create an image editor class that doesn't have a 'make_subsize' method. Also, wp_get_image_editor() requires a $file name, so I'll need to make a new file to hold this class. Am I thinking about this correctly, and if so, where should I put that file? Thanks!

[adamsilverstein]

Hey @johnregan3 - thanks for offering to help here!

Reviewing our test files, it looks like you would need to implement a new image class that lacks a make_subsize function to do this testing. I'm not sure what else you will need to implement there, you can probably start with a copy of the existing GD class, then remove anything that isn't needed.

[johnregan3]

@adamsilverstein Great. Thanks! Is there a good directory for me to put that file in?

[adamsilverstein]

In the folder tests/phpunit/tests/image/ along with the other image test files should be good.

[johnregan3]

Perfect. Thanks!

[adamsilverstein]

This is no longer needed as the multi-mime code was reverted in [54085]. Closing.