Context Navigation

← Previous Ticket
Next Ticket →

#56333 closed enhancement (fixed)

Remove _wp_image_belongs_to_attachment function

Reported by:	mukesh27	Owned by:	adamsilverstein
Priority:	normal	Milestone:	6.1
Component:	Media	Version:	6.1
Severity:	normal	Keywords:	has-patch
Cc:		Focuses:

Description

In #55443, we introduced _wp_image_belongs_to_attachment() to skip already existing image files, but we changed the approach to ensure unique filenames and changed the generate_filename function.

Check out the comment on the PR here: https://github.com/WordPress/wordpress-develop/pull/2393#issuecomment-1185012318

Change History (6)

This ticket was mentioned in PR #3061 on WordPress/wordpress-develop by mukeshpanchal27.

4 years ago #1

Keywords has-patch added; needs-patch removed

Trac ticket: https://core.trac.wordpress.org/ticket/56333

#2 @adamsilverstein
4 years ago

Good catch @mukesh27 this was part of the original code, but we changed the approach and this is no longer used or needed.

This ticket was mentioned in PR #3070 on WordPress/wordpress-develop by adamsilverstein.

4 years ago #3

Trac ticket:

#4 @adamsilverstein
4 years ago

Resolution → fixed
Status assigned → closed

In 53845:

Media: remove unused _wp_image_belongs_to_attachment function.

Remove the _wp_image_belongs_to_attachment function which was left over from a an unused branch and added inadvertently as part of r53751.

Props mukesh27.
Fixes #56333.

mukeshpanchal27 commented on PR #3061:

4 years ago #5

Fixed in https://core.trac.wordpress.org/changeset/53845

This ticket was mentioned in Slack in #core-media by antpb. View the logs.

4 years ago

Note: See TracTickets for help on using tickets.

Download in other formats:

Make WordPress Core

Context Navigation

#56333 closed enhancement (fixed)

Remove _wp_image_belongs_to_attachment function

Description

Change History (6)

This ticket was mentioned in ​PR #3061 on ​WordPress/wordpress-develop by ​mukeshpanchal27. 4 years ago #1

#2 @adamsilverstein 4 years ago

This ticket was mentioned in ​PR #3070 on ​WordPress/wordpress-develop by ​adamsilverstein. 4 years ago #3

#4 @adamsilverstein 4 years ago

​mukeshpanchal27 commented on ​PR #3061: 4 years ago #5

This ticket was mentioned in ​Slack in #core-media by antpb. ​View the logs. 4 years ago