Opened 2 years ago
Closed 2 years ago
#56383 closed task (blessed) (fixed)
Import Twenty Twenty-Three
Reported by: | audrasjb | Owned by: | desrosj |
---|---|---|---|
Milestone: | 6.1 | Priority: | normal |
Severity: | normal | Version: | |
Component: | Bundled Theme | Keywords: | has-patch has-unit-tests commit dev-reviewed i18n-change |
Focuses: | Cc: |
Description
The default theme for 2023 should be added to trunk/wp-content/themes
in time for the feature freeze on September 20, 2022.
Twenty Twenty-Three is currently being developed on this GitHub repository: https://github.com/WordPress/twentytwentythree/
Previously: #54318.
Change History (35)
#1
@
2 years ago
- Keywords needs-patch added
- Owner set to desrosj
- Status changed from new to assigned
This ticket was mentioned in PR #3280 on WordPress/wordpress-develop by mikachan.
2 years ago
#2
- Keywords has-patch added; needs-patch removed
This PR is the initial bulk merge for the new default theme, Twenty Twenty-Three (https://github.com/WordPress/twentytwentythree).
Trac ticket: https://core.trac.wordpress.org/ticket/56383
This ticket was mentioned in PR #3281 on WordPress/wordpress-develop by desrosj.
2 years ago
#3
- Keywords has-unit-tests added
This is blocked until #3280 is merged.
Trac ticket: https://core.trac.wordpress.org/ticket/56383
2 years ago
#6
Merged in https://core.trac.wordpress.org/changeset/54235.
Follow up commit of #3281 to follow.
This ticket was mentioned in PR #3330 on WordPress/wordpress-develop by mikachan.
2 years ago
#9
This PR syncs the latest changes from the Twenty Twenty-Three repo (https://github.com/WordPress/twentytwentythree), ahead of Beta 2.
Trac ticket: https://core.trac.wordpress.org/ticket/56383
This ticket was mentioned in PR #3397 on WordPress/wordpress-develop by mikachan.
2 years ago
#11
This PR syncs the latest changes from the Twenty Twenty-Three repo (https://github.com/WordPress/twentytwentythree), ahead of Beta 3.
Trac ticket: https://core.trac.wordpress.org/ticket/56383
2 years ago
#14
Thanks @mikachan! Merged into Core in https://core.trac.wordpress.org/changeset/54372.
This ticket was mentioned in PR #3427 on WordPress/wordpress-develop by mikachan.
2 years ago
#15
This PR syncs the latest changes from the Twenty Twenty-Three repo (https://github.com/WordPress/twentytwentythree), ahead of RC1.
Trac ticket: https://core.trac.wordpress.org/ticket/56383
cc. @desrosj
2 years ago
#17
Merged into Core in https://core.trac.wordpress.org/changeset/54467.
This ticket was mentioned in PR #3482 on WordPress/wordpress-develop by @mikachan.
2 years ago
#18
This PR syncs the latest changes from the Twenty Twenty-Three repo (https://github.com/WordPress/twentytwentythree), ahead of RC2.
Trac ticket: https://core.trac.wordpress.org/ticket/56383
cc. @desrosj
#19
@
2 years ago
- Resolution fixed deleted
- Status changed from closed to reopened
Reopening to review the RC2 sync.
#20
@
2 years ago
- Keywords commit dev-feedback added
PR looks good. Flagging for a second committer review.
#21
@
2 years ago
- Keywords dev-reviewed added; dev-feedback removed
PR LGTM based on a read through of the code.
This ticket was mentioned in PR #3520 on WordPress/wordpress-develop by @mikachan.
2 years ago
#24
This PR syncs the latest changes from the Twenty Twenty-Three repo (https://github.com/WordPress/twentytwentythree), ahead of RC3.
Trac ticket: https://core.trac.wordpress.org/ticket/56383
cc. @desrosj
@mikachan commented on PR #3520:
2 years ago
#25
Thanks for taking a look, @desrosj.
I've reverted the 'Comments' template part name change, as this was only a small change to make it easier to distinguish between template parts and blocks (there is also a block called 'Comments').
However, I believe the theme description change was requested by someone on the Polyglots team. This is the original PR, and here is the Slack conversation where this was first mentioned. The change to the description was requested because the current description is difficult to translate from English. I understand if this still can't be included, but in this case, it seems likely to be welcomed by the Polyglots team.
2 years ago
#26
However, I believe the theme description change was requested by someone on the Polyglots team. This is the original PR, and here is the Slack conversation where this was first mentioned. The change to the description was requested because the current description is difficult to translate from English. I understand if this still can't be included, but in this case, it seems likely to be welcomed by the Polyglots team.
Ah ha! Thanks for that additional context! Let me get some additional input to make sure this is an exception we can make. It seems reasonable.
#27
@
2 years ago
- Keywords dev-reviewed removed
- Resolution fixed deleted
- Status changed from closed to reopened
Reopening to include the latest PR.
#29
@
2 years ago
- Keywords dev-feedback added
Marking for a second committer sign off to backport to the 6.1 branch.
#30
@
2 years ago
- Keywords i18n-change added
Since this is a string change, marking i18n-change
. I will ping #polyglots in Core Slack after backporting.
Self-assigning as I've agreed to run point on merging.