Make WordPress Core

Opened 2 years ago

Closed 2 years ago

Last modified 2 years ago

#56402 closed defect (bug) (fixed)

Moment.js should be upgraded, 2.29.2 contains vulnerability

Reported by: jkfoiztmcjeikfp's profile jkfoiztmcjeikfp Owned by: sergeybiryukov's profile SergeyBiryukov
Milestone: 6.0.2 Priority: normal
Severity: normal Version: 6.0
Component: External Libraries Keywords:
Focuses: javascript Cc:

Description

Moment.js should be upgraded to the newest patch version (at least 2.29.4) to fix a CVE with base score 7.5 (high).

Quote:

moment is a JavaScript date library for parsing, validating, manipulating, and formatting dates. Affected versions of moment were found to use an inefficient parsing algorithm. Specifically using string-to-date parsing in moment (more specifically rfc2822 parsing, which is tried by default) has quadratic complexity on specific inputs. Users may notice a noticeable slowdown is observed with inputs above 10k characters. Users who pass user-provided strings without sanity length checks to moment constructor are vulnerable to (Re)DoS attacks. The problem is patched in 2.29.4, the patch can be applied to all affected versions with minimal tweaking. Users are advised to upgrade. Users unable to upgrade should consider limiting date lengths accepted from user input.

See here: https://nvd.nist.gov/vuln/detail/CVE-2022-31129

I am reporting it here, because the CVE is already published. Also the form on HackerOne is too long.

Change History (3)

#1 @audrasjb
2 years ago

  • Milestone changed from Awaiting Review to 6.0.2
  • Severity changed from critical to normal
  • Version changed from trunk to 6.0

Hello @jkfoiztmcjeikfp and welcome to WordPress Core Trac,

trunk is currently running version 2.29.4, as per changeset [53725] (see ticket #56031).

Moving this ticket to milestone 6.0.2 so a backport of this upgrade could possibly be considered for the next minor release.

Also changing Version from trunk to 6.0 since trunk was already updated.

#2 @SergeyBiryukov
2 years ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 53926:

External Libraries: Update the Moment library to version 2.29.4.

This is a minor bug fix release.

Props dilipbheda, desrosj, jkfoiztmcjeikfp, audrasjb.
Merges [53662] and [53725] to the 6.0 branch.
Fixes #56402. See #56031.

This ticket was mentioned in Slack in #core by costdev. View the logs.


2 years ago

Note: See TracTickets for help on using tickets.