Make WordPress Core

Opened 21 months ago

Last modified 21 months ago

#56403 reviewing defect (bug)

Write 'Activated' instead of 'Installed' for activated theme

Reported by: alireyad's profile alireyad Owned by: audrasjb's profile audrasjb
Milestone: Awaiting Review Priority: normal
Severity: normal Version:
Component: Themes Keywords: reporter-feedback has-patch
Focuses: javascript Cc:

Description

On theme-install page, there have text for all installed theme but it should be 'Activated' instead of 'Installed' for activated theme.

Attachments (6)

Capture d’écran 2022-08-18 à 11.11.49.png (896.2 KB) - added by audrasjb 21 months ago.
Current implementation
56403.diff (5.2 KB) - added by alireyad 21 months ago.
Created patch.
Capture d’écran 2022-08-18 à 13.11.08.png (896.2 KB) - added by audrasjb 21 months ago.
theme-install.png (139.9 KB) - added by alireyad 21 months ago.
themes.png (134.0 KB) - added by alireyad 21 months ago.
theme-install page also will match with themes page
56403.2.diff (1.4 KB) - added by alireyad 21 months ago.
Updated patch file. It also will match with themes page.

Change History (11)

#1 @audrasjb
21 months ago

  • Component changed from Text Changes to Themes
  • Owner set to audrasjb
  • Status changed from new to reviewing
  • Type changed from enhancement to defect (bug)
  • Version trunk deleted

@audrasjb
21 months ago

Current implementation

#2 @audrasjb
21 months ago

  • Keywords reporter-feedback added

Hello @alireyad welcome to WordPress Core Trac and thank you for opening this ticket,

I may be misunderstanding the issue, but the current implementation looks good to me. There's a difference between:

  • Installed themes (may be several items)
  • Installed AND activated theme (only one item).

@alireyad
21 months ago

Created patch.

#3 @audrasjb
21 months ago

  • Keywords has-patch added

Alright, but I have some concerns about duplicating the "Active/Activated" mention. See screenshot below.

Please note that the patch contains some unrelated file changes (but it can eventually be cleaned up before commit).

#4 @SergeyBiryukov
21 months ago

Hi there, welcome to WordPress Trac! Thanks for the ticket!

I think I agree with @audrasjb here. For the purpose of the Add Themes screen, the relevant information to know is which themes are already installed, and the activated theme is already marked as such next to the theme name.

So the current implementation makes sense to me and I'm not sure if it needs any changes.

@alireyad
21 months ago

theme-install page also will match with themes page

@alireyad
21 months ago

Updated patch file. It also will match with themes page.

#5 @alireyad
21 months ago

Yes, activate button which is disabled for activated theme is not focusable. So I think, 'Activated' text instead of 'Installed' would be more focusable because upper part is focused for activated and installed theme.

On the other hand, it also will match with themes page.

Note: See TracTickets for help on using tickets.