Change History (13)
This ticket was mentioned in PR #3148 on WordPress/wordpress-develop by robinwpdeveloper.
4 years ago
#1
- Keywords has-patch added; needs-patch removed
#3
@
4 years ago
- Keywords changes-requested added
I've reviewed the PR and asked for some changes. Updating the ticket with changes-requested to reflect that.
This ticket was mentioned in Slack in #core-committers by desrosj. View the logs.
4 years ago
robinwpdeveloper commented on PR #3148:
4 years ago
#5
Thanks @desrosj
I have updated as per your requested changes.
Can you please re review?
#6
@
4 years ago
Since the requested changes are made
can we remove the keyword “changes-requested”?
robinwpdeveloper commented on PR #3148:
4 years ago
#8
Hi @desrosj
I have fixed as per changesheet (manually did this).
Still 3 files has conflict.
Can you please fix these for me?
Or, let me know how to fix these conflicts.
Thanks.
4 years ago
#9
Thanks @robinwpdeveloper! I am going to commit this and I'll fix those oddities during that process. There are a few additional changes that happened over the last week that will require another change to the version. But I'll also handle those.
4 years ago
#11
Merged into Core in https://core.trac.wordpress.org/changeset/54492.
![(please configure the [header_logo] section in trac.ini)](/chrome/site/your_project_logo.png)
Trac ticket: 56450