#56457 closed enhancement (fixed)
WPCS: Self closing tags are not property closed.
Reported by: | haritpanchal | Owned by: | audrasjb |
---|---|---|---|
Milestone: | 6.1 | Priority: | normal |
Severity: | minor | Version: | |
Component: | Administration | Keywords: | has-patch |
Focuses: | coding-standards | Cc: |
Description
All tags must be properly closed. For tags that are self-closing, the forward slash should have exactly one space preceding it. I found several <br /> tags closed improperly as <br/>. According to coding standards, it should close in <br /> aw
Attachments (1)
Change History (10)
#2
@
2 years ago
- Focuses docs removed
- Milestone changed from Awaiting Review to 6.1
- Severity changed from major to minor
- Version 6.0.1 deleted
For tags that are self-closing, the forward slash should have exactly one space preceding it:
<br />
rather than the compact but incorrect:<br>
HTML Coding Standards - Self-closing Elements
- Removing
Version
as the patch touches lines added across multiple versions of WordPress.
This ticket was mentioned in Slack in #core by audrasjb. View the logs.
2 years ago
#4
@
2 years ago
- Owner set to audrasjb
- Status changed from new to reviewing
Reviewed during today's bug scrub.
It would be nice to run unit tests on this before commit, just in case some html content/strings are used by existing unit tests.
Self assigning for unit tests run and (most probably) commit
This ticket was mentioned in PR #3168 on WordPress/wordpress-develop by audrasjb.
2 years ago
#5
Trac ticket: https://core.trac.wordpress.org/ticket/56457
2 years ago
#8
Committed in https://core.trac.wordpress.org/changeset/54062
Patch Added