Opened 13 months ago
Closed 12 months ago
#56462 closed defect (bug) (fixed)
Twenty Eleven: Table thead color not reflected in editor and front side
Reported by: |
|
Owned by: |
|
---|---|---|---|
Milestone: | 6.1 | Priority: | normal |
Severity: | normal | Version: | |
Component: | Bundled Theme | Keywords: | has-patch has-screenshots commit |
Focuses: | ui, css | Cc: |
Description (last modified by )
Table thead color not reflected in editor and front side
1: Activate the Twenty Eleven Theme
2: Add table
3: Select text color in table
Attaching a video link for better understanding.
https://www.loom.com/share/d7d5eced7f864ef598bc37bd09ada34f
Attachments (5)
Change History (11)
#1
@
13 months ago
- Description modified (diff)
- Keywords has-patch added; needs-patch removed
- Version 6.0.1 deleted
#2
@
13 months ago
- Summary changed from Theme Twenty Eleven: Table thead color not reflected in editor and front side to Twenty Eleven: Table thead color not reflected in editor and front side
#3
@
13 months ago
- Keywords reporter-feedback added
- Milestone changed from Awaiting Review to 6.1
Hi there!
Thanks for the ticket and patch. It does not work for the editor. Is it working for you? In my case I have to update the selector class.
.editor-styles-wrapper .wp-block-table th, .editor-styles-wrapper .wp-block-table td { padding: 0; color: currentColor; }
#4
@
13 months ago
- Keywords has-screenshots added; reporter-feedback removed
Some people may prefer the gray text for header cells when they select a text color for the data cells, though matching header and body cell colors may be the better choice (especially if the table has a background color). When users do not select their own text color, the header cells should remain gray.
In the editor, the .editor-block-list__block
class became .block-editor-block-list__block
several releases ago. I like the proposal to use .editor-styles-wrapper
instead. The cell padding should not have been zero anyway, so I fixed the values in the editor and mirrored them for RTL on the front end as well.
Taking it further beyond the original scope, 56462.2.patch includes editor styles for the caption and the border below it. The wp-block-
class is no longer first in the classes list.
(If you're wondering about some English text strings in the Hebrew screenshots, the Gutenberg plugin is not fully translated.)
added patch