Make WordPress Core

#56466 closed defect (bug) (fixed)

Twenty Twelve: table block text color not reflected in editor

Reported by: nidhidhandhukiya's profile nidhidhandhukiya Owned by: audrasjb's profile audrasjb
Milestone: 6.2 Priority: normal
Severity: minor Version:
Component: Bundled Theme Keywords: has-patch commit
Focuses: css Cc:

Description

Steps to reproduce.

  1. Choose Twenty Twelve theme.
  2. Choose Table block.
  3. Give color to text.

It is not reflected in editor side.

I have attached video URL for better understanding.
URL:- https://share.cleanshot.com/JCLZXJhiNqyK8FPZ2T5Y

Attachments (7)

56466.patch (440 bytes) - added by nidhidhandhukiya 22 months ago.
tables-classic-default-colors.png (17.8 KB) - added by sabernhardt 21 months ago.
default td cells inherit the same #757575 gray text color from the table element, even in Classic Editor
56466.1.patch (1.3 KB) - added by sabernhardt 21 months ago.
making the table header cells inherit text colors, too (when user selects a text color)
tables-2012-editor-before.png (133.0 KB) - added by sabernhardt 21 months ago.
table blocks in the editor before patch
tables-2012-editor-with-patch.png (133.8 KB) - added by sabernhardt 21 months ago.
table blocks in the editor with 56466.1.patch
tables-2012-front-before.png (97.5 KB) - added by sabernhardt 21 months ago.
front end: page of table blocks before patch
tables-2012-front-with-patch.png (97.4 KB) - added by sabernhardt 21 months ago.
front end: page of table blocks with 56466.1.patch

Download all attachments as: .zip

Change History (13)

#1 @nidhidhandhukiya
22 months ago

  • Keywords has-patch has-unit-tests added

#2 @sabernhardt
21 months ago

  • Keywords has-unit-tests removed
  • Summary changed from Tewnty Twelve table text color issue in editor side. to Twenty Twelve: table block text color not reflected in editor
  • Version 6.0.1 deleted

@sabernhardt
21 months ago

default td cells inherit the same #757575 gray text color from the table element, even in Classic Editor

@sabernhardt
21 months ago

making the table header cells inherit text colors, too (when user selects a text color)

@sabernhardt
21 months ago

table blocks in the editor before patch

@sabernhardt
21 months ago

table blocks in the editor with 56466.1.patch

@sabernhardt
21 months ago

front end: page of table blocks before patch

@sabernhardt
21 months ago

front end: page of table blocks with 56466.1.patch

#3 @sabernhardt
21 months ago

  • Milestone changed from Awaiting Review to 6.2

Thanks! Your patch inherits the proper colors for the td cells, and I would like to match user-defined text colors for the header cells, too.

The screenshots show the Default style. The Stripes style does not support light text colors or dark background colors, but I think the editor could fix that instead of individual themes.

#4 @poena
17 months ago

  • Keywords commit added

Test Report

This report validates that the indicated patch addresses the issue.

Patch tested: https://core.trac.wordpress.org/attachment/ticket/56466/56466.1.patch

Environment

  • OS: macOS 13.1
  • Web Server: Nginx
  • PHP: 8.0.22
  • WordPress: 6.2-alpha-55225
  • Browser: Chrome
  • Theme: Twenty Twenty Twelve
  • Active Plugins:
    • WordPress Beta Tester 3.2.6

Actual Results

  • ✅ Issue resolved with patch.

#5 @faguni22
17 months ago

Test Report

This report validates that the indicated patch addresses the issue.

Patch tested: https://core.trac.wordpress.org/attachment/ticket/56466/56466.1.patch

Environment

  • OS: macOS 12.6
  • Web Server: Nginx
  • PHP: 7.4.33
  • WordPress: 6.2-alpha-54642-src
  • Browser: Google Chrome 109.0.5414.119
  • Theme: Twenty Twelve
  • Active Plugins:
    • No plugin

Actual Results

  • ✅ Issue resolved with patch.

Supplemental Artifacts

I've found the issue while activated Twenty Twelve theme, Before ss: https://d.pr/i/lzlWKD
After apllying the patch, the issue was resolved. After ss: https://d.pr/i/QkLatv

#6 @audrasjb
16 months ago

  • Owner set to audrasjb
  • Resolution set to fixed
  • Status changed from new to closed

In 55312:

Twenty Twelve: Properly reflect text color changes in Table block.

This changeset makes the table header cells also inherit text colors, when the user selects a text color.

Props nidhidhandhukiya, sabernhardt, poena, faguni22.
Fixes #56466.

Note: See TracTickets for help on using tickets.