WordPress.org
Get WordPress

Make WordPress Core

Opened 2 years ago

Closed 2 years ago

#56476 closed enhancement (fixed)

Twenty Twenty-One: Comment missing at the end of HTML tag in author-bio.php

Reported by: haritpanchal's profile haritpanchal Owned by: sergeybiryukov's profile SergeyBiryukov
Milestone: 6.2 Priority: normal
Severity: normal Version: 6.0.1
Component: Bundled Theme Keywords: has-patch
Focuses: coding-standards Cc:

Description

In the twentytwentyone theme, A comment is missing at the end of the HTML tag. As per WordPress coding standards, a comment should be there to show which HTML tag is ended.

Attachments (2)

56476.patch​ (589 bytes) - added by haritpanchal 2 years ago.
Patch Added
56476.2.patch​ (583 bytes) - added by haritpanchal 2 years ago.
Patch Updated

Download all attachments as: .zip

Change History (8)

@haritpanchal
2 years ago

Patch Added

#1 @haritpanchal
2 years ago

  • Keywords has-patch added; needs-patch removed

@haritpanchal
2 years ago

Patch Updated

#2 @haritpanchal
2 years ago

  • Summary changed from Twenty Twenty-One: Comment missing at the end of HTML tag in author-bio,php to Twenty Twenty-One: Comment missing at the end of HTML tag in author-bio.php

#3 @sabernhardt
2 years ago

  • Milestone changed from Awaiting Review to 6.2

This would make the author title consistent with comments-title.

#4 @mukesh27
2 years ago

Agreed with the @sabernhardt.

Ping @SergeyBiryukov for final review and commit.

#5 in reply to: ↑ description @SergeyBiryukov
2 years ago

Hi there, thanks for the patch!

Replying to haritpanchal:

As per WordPress coding standards, a comment should be there to show which HTML tag is ended.

FWIW, I could not find anything to that effect in the ​HTML coding standards, would appreciate a link if it's documented elsewhere.

Still, the patch brings some consistency, so looks good to me :)

#6 @SergeyBiryukov
2 years ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 54886:

Twenty Twenty-One: Add a comment for the closing h2 tag in author info template.

This brings consistency with the .comments-title heading in the comments.php template.

Follow-up to [49216], [50234].

Props haritpanchal, sabernhardt, mukesh27.
Fixes #56476.

Note: See TracTickets for help on using tickets.