Make WordPress Core

Changes between Initial Version and Version 1 of Ticket #56484, comment 4


Ignore:
Timestamp:
09/01/2022 02:03:27 PM (3 years ago)
Author:
SergeyBiryukov
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #56484, comment 4

    initial v1  
    33I had a concern about whether this method would be available in custom database drop-ins (`wp-content/db.php`), but it looks like they are [source:tags/6.0.2/src/wp-includes/load.php?marks=548-550#L537 loaded after wpdb], and are supposed to extend the class, rather than completely replace it, though technically the latter is possible too.
    44
    5 @Clorith, do you this change is safe as is, or should we check if the method exists, just in case, and fall back to the current code if it doesn't? Upon a quick check, popular drop-ins like [https://wordpress.org/plugins/hyperdb/ HyperDB] extend the `wpdb` class, so the patch seems good to go.
     5@Clorith, do you think this change is safe as is, or should we check if the method exists, just in case, and fall back to the current code if it doesn't? Upon a quick check, popular drop-ins like [https://wordpress.org/plugins/hyperdb/ HyperDB] extend the `wpdb` class, so the patch seems good to go.