PHP Deprecated: rtrim(): Passing null to parameter #1 ($string) of type string

[hiren1094]

Hello,

Updated "wp-includes\formatting.php" files for fix issue of "PHP Deprecated: rtrim(): Passing null to parameter #1 ($string) of type string is deprecated" for PHP 8.1.6

[hiren1094]

Patch Added

[jrf]

Deprecations are not errors. A lot of WordPress functions all suffer from similar issues and we should implement a proper, consistent solution for all, which is why these issues have not been addressed yet as a discussion is needed on the solution direction.

The only time it would be possible to get these deprecation notices, is if these functions are being called with a null being passed to a non-nullable parameter, which is doing it wrong. More than anything, the incorrect function call, should be fixed. Not the function where the deprecation is thrown.

For that a full backtrace of the notices is needed to determine where the incorrect function call is being made.

Note: I've also looked at the patch and this is not a correct fix no matter what. The input type is not being checked and the return type will now potentially widen, which is undesirable and could cause new issues with null now being returned as null (and potentially other wrong types not handled either).

[SergeyBiryukov]

Hi there, welcome to WordPress Trac!

Thanks for the report, we're already tracking this issue in #54997.