Make WordPress Core

Opened 23 months ago

Closed 4 months ago

Last modified 4 months ago

#56524 closed defect (bug) (fixed)

Twenty Eleven: "Add Citation" Text Color issue in Pullquote Block

Reported by: kajalgohel's profile kajalgohel Owned by: karmatosed's profile karmatosed
Milestone: 6.6 Priority: normal
Severity: normal Version: 6.0.2
Component: Bundled Theme Keywords: has-patch
Focuses: ui, css Cc:

Description

In Twenty Eleven Theme, when we add Pullquote block in editor side, and choose text color, We can see that the text color is reflected for "Add quote" and "Add citation" text.But when we see the same Pullquote block at front side, text color for "Add citation" text is not reflected.

Steps to replicate:
1: Activate the Twenty Eleven Theme
2: Add Pullquote block
3: Enter some Text for "Add quote"
4: Enter some Text for "Add citation"
6: Choose Text color
7: Save Page/Post
8: View the page/post at front side

For better understanding I provide video attachment link.
Video URL : https://share.cleanshot.com/wZpuZo9ZCN9xpSHzIb7s

Thanks

Attachments (5)

#56524.patch (424 bytes) - added by kajalgohel 23 months ago.
patch added
SCR-20240328-pulh.png (24.1 KB) - added by karmatosed 4 months ago.
Without patch
SCR-20240328-puhz.png (24.7 KB) - added by karmatosed 4 months ago.
With patch
2011-Pullquotes-6.5RC4.png (27.1 KB) - added by sabernhardt 4 months ago.
before: citation was set to #141412 when the block had the default text color or the theme's blue
2011-Pullquotes-r57896.png (27.8 KB) - added by sabernhardt 4 months ago.
after: citation inherits #373737 to match the paragraph when no text color is selected, and it inherits the theme's blue when chosen for the Pullquote block

Download all attachments as: .zip

Change History (13)

@kajalgohel
23 months ago

patch added

#1 @kajalgohel
23 months ago

  • Keywords has-patch added; needs-patch removed

#2 @kajalgohel
23 months ago

  • Summary changed from Twenty Eleven: CitationText Color issue in Pullquote Block to Twenty Eleven: "Add Citation" Text Color issue in Pullquote Block

@karmatosed
4 months ago

Without patch

@karmatosed
4 months ago

With patch

#3 @karmatosed
4 months ago

  • Keywords commit added

I can replicate the issue and the patch does fix it. This means for me that I would flag for commit as it is a smaller patch which does resolve the issue.

Thank you for your collaboration on this @kajalgohel.

#4 @karmatosed
4 months ago

  • Owner set to karmatosed
  • Resolution set to fixed
  • Status changed from new to closed

In 57896:

Twenty Eleven: Fixes adding citation text color issue in pullquote block.

The pullquote block wasn't reflecting text color added for quote and add citation text across the front and back of editor. This fixes that by adding ensuring whatever color is selected is shown in both

Props kajalgohel.
Fixes #56524.

@sabernhardt
4 months ago

before: citation was set to #141412 when the block had the default text color or the theme's blue

@sabernhardt
4 months ago

after: citation inherits #373737 to match the paragraph when no text color is selected, and it inherits the theme's blue when chosen for the Pullquote block

#5 @sabernhardt
4 months ago

  • Keywords commit removed
  • Milestone changed from Awaiting Review to 6.6

Inheriting the text color affects the citation color when the user does not select a color for the block, yet in this case it seems reasonable.

  • [43794] only added the #141412 color in blocks.css, not editor-blocks.css, and I did not find that color anywhere else in Twenty Eleven.
  • The difference between #141412 and #373737 is minor with a ratio of 1.54:1 (or against a white background, the ratios are 18.44:1 for #141412 and 11.9:1 for #373737).
  • The code change in [57896] is simpler than adjusting the color only when the block has the .has-text-color and/or .has-background classes.

For the screenshots, I edited the code element font-size and/or text-transform to make the inline code more readable. The colors and other styles should be accurate.

#6 @karmatosed
4 months ago

@sabernhardt I am unclear are you requesting the commit gets reverted or suggesting some iterations? I am totally happy with either of those options but trying to understand the next steps as it has been committed.

#7 @sabernhardt
4 months ago

I do not think it is worth reverting the change. Any similar tickets may require a different strategy, but the new default color seems acceptable for this theme.

#8 @karmatosed
4 months ago

Thank you for confirmation @sabernhardt. I agree it's tricky with these tickets. Adding stacks like this to block.css front/back isn't the best workaround situation. Thank you for the diligence in checking.

Note: See TracTickets for help on using tickets.