Make WordPress Core

Opened 3 years ago

Closed 11 months ago

#56525 closed defect (bug) (wontfix)

Twenty Eleven: Font-style issue of "Add Citation" text in Pullquote Block

Reported by: kajalgohel's profile kajalgohel Owned by:
Milestone: Priority: normal
Severity: normal Version: 6.0
Component: Bundled Theme Keywords: dev-feedback has-patch close
Focuses: ui, css Cc:

Description

In Twenty Eleven Theme, when we add Pullquote block in editor side, We can see that the font-style of "Add citation" text is Italic. But when we see the same Pullquote block at front side, font-style for "Add citation" text is not reflected, It is display normal.

Steps to replicate:
1: Activate the Twenty Eleven Theme
2: Add Pullquote block
3: Enter some Text for "Add quote"
4: Enter some Text for "Add citation"
5: Save Page/Post
6: View the page/post at front side

For better understanding I provide video attachment link.
Video URL : https://share.cleanshot.com/yoxXVomU1svauo5FmF9G

Thanks

Attachments (1)

56525.patch (446 bytes) - added by multidots1896 3 years ago.
added patch

Download all attachments as: .zip

Change History (9)

#1 @hilayt24
3 years ago

  • Keywords reporter-feedback added

Hi @kajalgohel , Thanks for the ticket I checked the issue and able to reproduce it.

Adding the following CSS will solve this issue:

     .wp-block-quote cite {
          font-style: inherit !important;
     }

Thanks
Hilay

#2 @costdev
3 years ago

  • Keywords dev-feedback added; reporter-feedback removed
  • Version changed from 6.0.2 to 6.0

After testing, this was introduced in WordPress 6.0 - more specifically, in Gutenberg 12.9.0. The respective Twenty Eleven styles haven't been changed in 11 years.

I haven't found the exact change in Gutenberg 12.9.0 that broke the Twenty Eleven styling. Having reviewed the PRs relating Pullquote changes, they don't appear relevant to me.

Pinging @ndiego who worked with the Pullquote for Gutenberg 12.9.0. Nick, do you have any thoughts on what caused this and whether this should be an issue on GitHub?

@multidots1896
3 years ago

added patch

#3 @karmatosed
15 months ago

  • Keywords has-patch added; needs-patch removed

This ticket was mentioned in Slack in #core-themes by karmatosed. View the logs.


15 months ago

#5 @karmatosed
14 months ago

I am reluctant to fix this at the theme level if it is something came in within block. cc @poena for your thoughts also.

#6 @karmatosed
12 months ago

  • Keywords changes-requested added

I am still very reluctant to fix this in theme level still. I also feel setting to a that font style doesn't fix as it brings in a change. Perhaps an inherit patch could work but the patch uploaded isn't that. For now, my recommendation would be to change this patch or close. I am going to suggest for a short while looking at getting another patch and considering even the block but if not let's close this.

#7 @karmatosed
12 months ago

  • Keywords close added; changes-requested removed

I still standby my recommendation to close to adding that label as no counters so far on this and no changes to the ticket. We can absolutely always have reopening but we do need to consider when something has just sat there for a while now.

#8 @karmatosed
11 months ago

  • Milestone Awaiting Review deleted
  • Resolution set to wontfix
  • Status changed from new to closed

For now I am going to close this but thank you everyone for the collaboration.

Note: See TracTickets for help on using tickets.