Make WordPress Core

Opened 22 months ago

Closed 5 weeks ago

#56537 closed defect (bug) (wontfix)

Twenty Nineteen: The latest posts block has alignment issue

Reported by: smit08's profile smit08 Owned by:
Milestone: Priority: normal
Severity: normal Version:
Component: Bundled Theme Keywords: has-screenshots has-testing-info has-patch close 2nd-opinion
Focuses: Cc:

Description

In the twenty nineteen theme, the latest posts block has a center alignment issue in the editor and front.

Steps to reproduce:

  1. Activate the twenty nineteen theme.
  2. Add the latest posts block.
  3. Set it in center alignment, and the format should be in list not in a grid format.
  4. You will now see the issue clearly that it is not in center alignment.

Attachments (4)

CleanShot 2022-09-09 at 00.03.52@2x.png (1.2 MB) - added by smit08 22 months ago.
center alignment issue in editor.
CleanShot 2022-09-09 at 00.03.58@2x.png (407.1 KB) - added by smit08 22 months ago.
center alignment issue in front.
#56537.patch (491 bytes) - added by hilayt24 22 months ago.
Adding the margin and align the text to center when needed.
56537.2.patch (1.3 KB) - added by smit08 21 months ago.
In this patch I have added the align center css at right position in both editor and front style css file. And also added the rtl css in file. hilay24 has added the new css which was not working and wrong. hilay24 patch was not working, so I created this patch and I have tested it and now it is solved in front, editor and rtl also.

Download all attachments as: .zip

Change History (10)

@smit08
22 months ago

center alignment issue in editor.

@smit08
22 months ago

center alignment issue in front.

#1 @hilayt24
22 months ago

  • Keywords has-patch added; needs-patch removed

After reviewing the ticket I confirm that this is theme specific issue so I am adding the patch for the 2019 theme.

@hilayt24
22 months ago

Adding the margin and align the text to center when needed.

@smit08
21 months ago

In this patch I have added the align center css at right position in both editor and front style css file. And also added the rtl css in file. hilay24 has added the new css which was not working and wrong. hilay24 patch was not working, so I created this patch and I have tested it and now it is solved in front, editor and rtl also.

#2 @hilayt24
21 months ago

Hi @smit08 , Can you please elaborate why my patch is wrong, as it is working , I checked and tested it also, if we just add the text align center you will notice that it is not perfectly align in the center. Please verify that also.

#3 @SergeyBiryukov
15 months ago

  • Summary changed from In Twenty Nineteen theme, the latest posts block has alignment issue. to Twenty Nineteen: The latest posts block has alignment issue

This ticket was mentioned in PR #6549 on WordPress/wordpress-develop by @sabernhardt.


5 weeks ago
#4

This centers the text of the Latest Posts block, if a user selects center alignment, grouping it in the same .aligncenter rule written for Archives and Categories List blocks. This also updates styles for all three blocks in the editor.

Trac 56537

#5 @sabernhardt
5 weeks ago

  • Keywords close 2nd-opinion added

Not centering the text of the Latest Posts block may have been intentional. PR 684 created a separate ruleset for Categories and Archives blocks, though adding an .aligncenter rule for all three blocks would have been easier.

A comment on the related issue discouraged centering text:

I think the block itself should be centered, not the individual lines. Centered text is difficult to read, and it destroys the hierarchy of the list structure.

If that change is worth making on the front end, then the editor styles fix for the Latest Posts block could be combined with the Archives and Categories List blocks (like in PR 6549, instead of the patch on #61186).

#6 @karmatosed
5 weeks ago

  • Milestone Awaiting Review deleted
  • Resolution set to wontfix
  • Status changed from new to closed

I agree with the recommendation to close so will now do that. Thank you everyone for the collaboration.

Note: See TracTickets for help on using tickets.