Make WordPress Core

Opened 22 months ago

Closed 3 weeks ago

#56557 closed enhancement (wontfix)

Twenty Twenty: Remove font size and weight definition on cite element

Reported by: joen's profile Joen Owned by:
Milestone: Priority: normal
Severity: normal Version: 5.3
Component: Bundled Theme Keywords: needs-patch has-screenshots close
Focuses: css Cc:

Description (last modified by sabernhardt)

The cite element in Twenty Twenty is styled in a way that makes it less flexible than it's meant to be, with a smaller font size and no italic. The W3Schools example uses the element to wrap the title of a painting, not the author, causing the title to have reduce emphasis (see tt-before.png).

The default styling for the cite element is to simply have italic text (see intended.png).

Suggestion: remove the font-weight, style, and size definitions from TT's cite element. See (tt-after.png)

Example block markup:

<!-- wp:list -->
<ul><!-- wp:list-item -->
<li><cite>Do Androids Dream of Electric Sheep</cite>, Philip K. Dick</li>
<!-- /wp:list-item -->

<!-- wp:list-item -->
<li><cite>Neuromancer</cite>, William Gibson</li>
<!-- /wp:list-item -->

<!-- wp:list-item -->
<li><cite>The Diamond Age</cite>, Neal Stephenson</li>
<!-- /wp:list-item --></ul>
<!-- /wp:list -->

Attachments (3)

tt-before.png (97.2 KB) - added by Joen 22 months ago.
TwentyTwenty as shipping
intended.png (72.8 KB) - added by Joen 22 months ago.
Traditional cite styling
tt-after.png (110.3 KB) - added by Joen 22 months ago.
Suggested styling

Download all attachments as: .zip

Change History (7)

@Joen
22 months ago

TwentyTwenty as shipping

@Joen
22 months ago

Traditional cite styling

@Joen
22 months ago

Suggested styling

#1 @krupalpanchal
22 months ago

  • Keywords needs-patch has-screenshots added

#2 @sabernhardt
22 months ago

  • Component changed from Themes to Bundled Theme
  • Description modified (diff)
  • Focuses css added
  • Summary changed from TwentyTwenty: Remove font size and weight definition on cite element to Twenty Twenty: Remove font size and weight definition on cite element
  • Type changed from defect (bug) to enhancement
  • Version changed from trunk to 5.3

I'm nervous about changing this after the theme became public. I think people will expect these styles to remain as they are, at least within the blockquote element. Maybe the stylesheet could use :where(blockquote) cite for the weight and size to avoid increasing specificity.

The different font-family might be more problematic than size or weight with content like your example. The sans-serif Inter font stands out much more against Noto Serif than Garamond. If updating the font selectors, that would involve the twentytwenty_get_localized_font_family_elements arrays in addition to style.css and style-rtl.css.

#3 @karmatosed
3 weeks ago

  • Keywords close added

I am also seconding the approach of not changing this. My recommendation would be to close for now and will add that keyword as a suggesting, we can always revise this if others have alternative feelings. My recommendation is based on:

  • The time since this was reported and the theme being public with this in it.
  • Our current focus on bugs not enhancements for default themes.

If however a decision is taken this isn't the right approach I would back the use of :where but my concern is there is for now a limit to how we approach these historic themes until we have a more unified way. Now getting that is another conversation.

#4 @karmatosed
3 weeks ago

  • Milestone Awaiting Review deleted
  • Resolution set to wontfix
  • Status changed from new to closed

I am going to follow through closing this now. Thank you everyone for collaboration on this.

Note: See TracTickets for help on using tickets.