Make WordPress Core

Opened 4 years ago

Closed 2 years ago

#56565 closed defect (bug) (fixed)

Twenty Sixteen: Quote Block Border Left color not reflected in editor

Reported by: umesh84 Owned by: karmatosed
Priority: normal Milestone: 6.7
Component: Bundled Theme Version: 6.0.2
Severity: minor Keywords: has-patch has-screenshots commit
Cc: Focuses: ui, css

Description

Theme Twenty Sixteen Quote Block Border Left color not reflected in editor
Steps to replicate:

1: Activate the Twenty Sixteen Themes
2: add Quote block
3: Select color

For better understanding I provide video attachment link.
Video link: https://www.loom.com/share/bc19aee1e3cb4370a0642a403c61942f

Attachments (2)

56565.patch (501 bytes ) - added by umesh84 4 years ago.
added patch
56565.1.patch (577 bytes ) - added by sabernhardt 3 years ago.
using the .wp-block-quote class and moving style among other Quote block styles

Download all attachments as: .zip

Change History (11)

@umesh84
4 years ago

added patch

#1 @umesh84
4 years ago

  • Keywords has-patch added; needs-patch removed

#2 @desrosj
4 years ago

  • Summary Theme Twenty Sixteen Quote Block Border Left color not reflected in editorTwenty Sixteen: Quote Block Border Left color not reflected in editor

@sabernhardt
3 years ago

using the .wp-block-quote class and moving style among other Quote block styles

#3 @sabernhardt
3 years ago

  • Severity normalminor

The original theme design did not have the same color for the border as the quote text, but it has been that way in the Quote block for about two years.

With WordPress 5.0, Twenty Sixteen had a black border color and #1a1a1a dark gray citation color while the quote text was in the #686868 medium gray. By 5.3, the theme.css gave its own dark gray border (GB13248), and later it was revised to match the text color in GB26684.

In case we want to match the current block styling, I updated the selector in the patch.

#4 @shailu25
3 years ago

  • Keywords has-screenshots added

Test Report For https://core.trac.wordpress.org/attachment/ticket/56565/56565.1.patch

Before Patch: https://prnt.sc/n7UigrkW1xZe

After Patch : https://prnt.sc/D-_YULQcYOQq

Result After Patch:

  • Quote Block Border Left color is reflected in editor.

https://core.trac.wordpress.org/attachment/ticket/56565/56565.1.patch is working fine.

#5 @sabernhardt
3 years ago

#60166 was marked as a duplicate.

#6 @sabernhardt
3 years ago

#60273 was marked as a duplicate.

#7 @karmatosed
2 years ago

  • Owner set to karmatosed
  • Status newassigned

I am going to assign this to myself to test and see if this does impact design or would work to commit.

#8 @karmatosed
2 years ago

  • Keywords commit added
  • Milestone Awaiting Review6.7

I think it is fair to expect this to change based on color particularly with the way that the editor works now. I am therefore going to add in the patch that is up. What this does is reflect the color change in border also.

#9 @karmatosed
2 years ago

  • Resolutionfixed
  • Status assignedclosed

In 58728:

Twenty Sixteen: Fixes quote block border not changing color.

The border was not changing color when it was changed. This brings that in. It is worth noting the original theme design did not have this but as noted in the ticket this has been in the quote block for about two years so matching the current block styling in this case makes sense.

Props umesh84, desrosj, sabernhardt.
Fixes #56565.

Note: See TracTickets for help on using tickets.