Docs: Wrong parameter type used for Walker_Nav_Menu class

[dilipbheda]

In class-walker-nav-menu.php nav_menu_item_id filter inline document define wrong @param type.
$menu_id @param should be int instead of string

Trac ticket: https://core.trac.wordpress.org/ticket/56574

Great catch @dilipbheda

[mukesh27]

Hi there!

Thanks for the ticket and patch.

$menu_item->ID is always integer value so this changes make sense. The PR is LGTM and approved.

Added ticket in 6.1 milestone for visibility.

[robinwpdeveloper]

My conclusion is existing code is alright!

Here all 4 param descriptions are for the filter.
First value of the filter is

'menu-item-' . $menu_item->ID

So, $menu_id is passed as string to the filter.

I haven’t tested the code by using the filter though.

Please correct me if I am wrong.

[dilipbheda]

@robinwpdeveloper Yes, you are right.

honestly, when I created a ticket, I failed to see the first argument properly.

I'm going to close this ticket.

Thank you all

[SergeyBiryukov]

In 54178:

Docs: Clarify documentation for the nav_menu_item_id filter.

This aims to make it clear that the filter is applied to an HTML ID attribute for the menu item's <li> element, and not a numeric ID.

Follow-up to [15407], [25410], [27201], [38559], [51739].

Props dilipbheda, robinwpdeveloper, mukesh27, audrasjb, SergeyBiryukov.
See #56574, #55646.

[SergeyBiryukov]

Hi there, thanks for the ticket!

Even if the previous documentation was technically correct, it looks like it could use some clarification.

[54178] should hopefully help avoid any further confusion :)