Change position of "Delete menu" action

[90lines]

Many have noticed a usability problem with the "delete menu" action on wp-admin/nav-menus.php. When editing a menu item the "delete menu" and "Remove" actions can be confusing. I think it would be more correct to combine this action with the "save menu" button so as to have a single area with the actions related to the selected menu.

By editing this nav menu css at row 853
​https://github.com/WordPress/WordPress/blob/master/wp-admin/css/nav-menus.css

.nav-menus-php .delete-action {
    float: right;
    line-height: 2.1;
    margin: 0 15px;
}

I found a solution that I think is more usable

​https://im.ge/i/11BSdy
​https://im.ge/i/11B1JJ
​https://im.ge/i/11BdPS

[90lines]

Appear on the same block

[sabernhardt]

Thanks for the report!

A patch on ticket:40822#comment:28 proposes to put the links together on the left side, similar to how they are positioned in Quick Edit and for editing Categories and Tags.

I'll close this as a duplicate so the conversation stays on one ticket. If you have anything to add, please comment on #40822.

[sabernhardt]

Reopening to address this separately from the task ticket #40822

[sabernhardt]

The other ticket had this pull request:
​https://github.com/WordPress/wordpress-develop/pull/3542

[costdev]

Test Report

This report validates that the indicated patch addresses the issue.

Patch tested: ​https://patch-diff.githubusercontent.com/raw/WordPress/wordpress-develop/pull/3542.diff

Environment

• WordPress: 6.3-beta3-56130
• PHP: 7.4.33
• Server: Apache/2.4.56 (Ubuntu)
• Database: mysqli (Server: 5.7.41-0ubuntu0.18.04.1 / Client: mysqlnd 7.4.33)
• Browser: Chrome, Firefox, Edge and Opera
• Theme: Twenty Twenty-One 1.8
• MU-Plugins: None activated
• Plugins:
  • WordPress Beta Tester 3.5.0.1

Actual Results

• ✅ The Save Menu button and Delete Menu link appear at the bottom left of the Menu structure section in all four browsers.
• ✅ Tab order is correct.

The patch works as expected.

[sabernhardt]

Let's revisit this for the next release cycle.

[joedolson]

In 56449:

Menus: Fix proximity of controls to Save and Delete menus.

Move the position of the Save and Delete buttons in menu editing so they are immediate neighbors, improving the proximity of related controls.

Props 90lines, sabernhardt, costdev.
See #56594.

[joedolson]

In 56450:

Menus: Revert unintentional changes in [56449].

Accidentally committed two simultaneous patches; reverting unintended list table changes.

Unprops joedolson.
See #56594.

[joedolson]

In 56453:

Build/Test: Revert unintentional .env change in [56449].

Also committed a change to .env. Sigh.

Unprops joedolson.
See #56594.

[joedolson]

Well, I did not do a great job of committing that changeset. Hopefully I've gotten everything caught up there.

Closed in [r56449], anyway.