Make WordPress Core

#56659 closed feature request (duplicate)

Test the build process for default themes

Reported by: desrosj's profile desrosj Owned by:
Milestone: Priority: normal
Severity: normal Version:
Component: Build/Test Tools Keywords: good-first-bug
Focuses: Cc:

Description

There are three bundled themes that have their own build process:

  • Twenty Nineteen
  • Twenty Twenty
  • Twenty Twenty-One

There is currently a Core workflow that confirms the main build scripts work correctly and as expected for all contributors. It would be great to also test the same for these default themes.

Change History (2)

#1 @desrosj
22 months ago

I think this would fit nicely in the test-npm.yml workflow that already exists. The things that should be tested:

  • npm install and npm run build complete without error.
  • The version-controlled files modified or deleted after building.

Also, it's worth noting that the other checks currently run (PHP compatibility and PHP coding standards) already include default themes. This one is a bit of an outlier.

These checks also don't need to run on every commit. It would be nice if path filters could be used at the job level, but that doesn't seem to be the case. push event payloads do include a list of files modified, but it won't be as easy to determine when one of these three themes are modified.

Last edited 22 months ago by desrosj (previous) (diff)

#2 @desrosj
21 months ago

  • Milestone Future Release deleted
  • Resolution set to duplicate
  • Status changed from new to closed

This will be solved as part of #56898.

Note: See TracTickets for help on using tickets.