Make WordPress Core

Changes between Initial Version and Version 1 of Ticket #56659, comment 1


Ignore:
Timestamp:
09/26/2022 04:40:37 PM (21 months ago)
Author:
desrosj
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #56659, comment 1

    initial v1  
    22- `npm install` and `npm run build` complete without error.
    33- The version-controlled files modified or deleted after building.
     4
     5Also, it's worth noting that the other checks currently run (PHP compatibility and PHP coding standards) already include default themes. This one is a bit of an outlier.
     6
     7These checks also don't need to run on every commit. It would be nice if [https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#onpushpull_requestpull_request_targetpathspaths-ignore path filters could be used at the job level], but that doesn't seem to be the case. `push` [https://docs.github.com/en/developers/webhooks-and-events/webhooks/webhook-events-and-payloads#push event payloads do include a list of files modified], but it won't be as easy to determine when one of these three themes are modified.