WordPress.org
Get WordPress

Make WordPress Core

Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#56667 closed defect (bug) (fixed)

Twenty Ten: Escape 'get_permalink' where appropriate in 'twentyten/functions.php'

Reported by: hztyfoon Owned by: audrasjb
Priority: normal Milestone: 6.1
Component: Bundled Theme Version:
Severity: normal Keywords: has-patch commit
Cc: Focuses: coding-standards

Description

In 'wp-content/themes/twentyten/functions.php' there are multiple instances where I think esc_url should be used.

To me, it's also a basic safety practice to use 'esc_url' where appropriate.
So, I think they should be escaped.

Change History (11)

This ticket was mentioned in ​PR #3343 on ​WordPress/wordpress-develop by ​hz-tyfoon.
4 years ago #1

  • Keywords has-patch added

…ityten)

Trac ticket: 56667

#2 @mukesh27
4 years ago

  • Component General → Bundled Theme

#3 @robinwpdeveloper
4 years ago

PR Looks good to me.
Thanks @hztyfoon

#4 @mukesh27
4 years ago

Hi there! Welcome to the Trac.

Thanks for the Ticket and PR!

The PR looks good to me. Approved.

#5 @rudlinkon
4 years ago

Thank you @hztyfoon the PR looks also good to me.

​fuadragib01 commented on ​PR #3343:
4 years ago #6

Ok, LGTM. Thank you @hz-tyfoon

#7 @SergeyBiryukov
4 years ago

  • Milestone Awaiting Review → 6.1
  • Summary Coding Standards: Escape 'get_permalink' where appropriate in 'twentyten/functions.php' → Twenty Ten: Escape 'get_permalink' where appropriate in 'twentyten/functions.php'

#8 @audrasjb
4 years ago

  • Owner set to audrasjb
  • Status new → reviewing

Self assigning for commit consideration.

#9 @audrasjb
4 years ago

  • Keywords commit added

OK, this would bring more consistency with coding standards, add also with ​other bundled themes.

#10 @audrasjb
4 years ago

  • Resolution → fixed
  • Status reviewing → closed

In 54341:

Twenty Ten: Escape get_permalink() where appropriate in functions.php file.

This changeset adds missing esc_url() to some instances of get_permalink() used in Twenty Ten, as per WordPress Coding Standards.

Props hztyfoon, robinwpdeveloper, mukesh27, rudlinkon, fuadragib01.
Fixes #56667.

Note: See TracTickets for help on using tickets.