Make WordPress Core

#56673 closed enhancement (fixed)

Remove floating on Permalinks settings screen

Reported by: sabernhardt's profile sabernhardt Owned by: audrasjb's profile audrasjb
Milestone: 6.2 Priority: normal
Severity: normal Version:
Component: Permalinks Keywords: has-patch has-screenshots commit
Focuses: css, administration Cc:

Description

Moved from #55557; follow-up to #55498.

Available structure tag buttons are floated in a horizontal list. The markup can stay the same to keep the elements' semantic value, but using CSS flex could replace the float.

Attachments (5)

55557-permalink-tags.2.diff (663 bytes) - added by sabernhardt 14 months ago.
@kebbet's patch: Only change CSS for permalinks screen.
Capture d’écran 2023-01-18 à 01.07.01.png (292.0 KB) - added by audrasjb 11 months ago.
Before patch
Capture d’écran 2023-01-18 à 01.07.15.png (295.8 KB) - added by audrasjb 11 months ago.
After patch
56673.diff (687 bytes) - added by sabernhardt 11 months ago.
Capture d’écran 2023-01-19 à 23.43.05.png (225.3 KB) - added by audrasjb 11 months ago.
Testing 56673.diff

Download all attachments as: .zip

Change History (10)

@sabernhardt
14 months ago

@kebbet's patch: Only change CSS for permalinks screen.

#1 @audrasjb
11 months ago

  • Keywords needs-testing added
  • Owner set to audrasjb
  • Status changed from new to reviewing

#2 @audrasjb
11 months ago

  • Keywords has-screenshots changes-requested added; needs-testing removed

The patch looks good to me, except that it introduces a line break on large screens (see screenshots above).

Would it be possible to keep the previous rendering?

@sabernhardt
11 months ago

#3 @sabernhardt
11 months ago

It had already wrapped on my 1366px screen with the margin from the last button, which these patches remove, but 56673.diff keeps the li elements' current spacing (vertical and horizontal).

#4 @audrasjb
11 months ago

  • Keywords commit added; changes-requested removed

Thanks for the change, it looks better on large screen! ✌️

Self-assigning for commit.

#5 @audrasjb
11 months ago

  • Resolution set to fixed
  • Status changed from reviewing to closed

In 55103:

Permalinks: Remove floating on Permalinks settings screen.

This changeset replaces floating elements with flex CSS positioning, while the markup stays the same to keep the elements' semantic value.

Follow-up to [53706].

Props sabernhardt, kebbet, audrasjb.
Fixes #56673.
See #55498.

Note: See TracTickets for help on using tickets.