Twenty Ten: Use 'esc_url' for 'get_author_posts_url' where appropriate

[hztyfoon]

Follow up: #56667
PR incoming...

Trac ticket: 56674

[robinwpdeveloper]

PR looks good to me.
Yes, we need to use esc_url() to maintain coding standards and for security purpose.

Thanks @hztyfoon

[mukesh27]

Hi there!

Thanks for the Ticket and PR!

The PR looks good to me. Approved

Moving to 6.1 milestones for visibility Feel free to change milestones.

[rudlinkon]

Replying to robinwpdeveloper:

PR looks good to me.
Yes, we need to use esc_url() to maintain coding standards and for security purpose.

Thanks @hztyfoon

Yes, I agree with you.

[audrasjb]

Removing from 6.1 as the beta cycle already started and this is not something introduced by 6.1.

[SergeyBiryukov]

Replying to audrasjb:

Removing from 6.1 as the beta cycle already started and this is not something introduced by 6.1.

Right, but I think this is just another coding standards update along the lines of [54341] / #56667. This would bring more consistency, as get_author_posts_url() appears to be escaped in other bundled themes, as well as in other files of the same theme (two links are escaped and two are not, which is fixed by this patch).

So if that change went in, it seems like this should go in too :) Otherwise we'd have to bump the theme version just for [54341], and then bump it again just for this patch.

[rudlinkon]

Replying to SergeyBiryukov:

Replying to audrasjb:

Removing from 6.1 as the beta cycle already started and this is not something introduced by 6.1.

Right, but I think this is just another coding standards update along the lines of [54341] / #56667. This would bring more consistency, as get_author_posts_url() appears to be escaped in other bundled themes, as well as in other files of the same theme (two links are escaped and two are not, which is fixed by this patch).

So if that change went in, it seems like this should go in too :) Otherwise we'd have to bump the theme version just for [54341], and then bump it again just for this patch.

Yes, you are right, I think this patch should publish in 6.1 because already some of this type of issue is accepted in 6.1 and this is not a big change.

[jakariaistauk]

Replying to SergeyBiryukov:

Replying to audrasjb:

Removing from 6.1 as the beta cycle already started and this is not something introduced by 6.1.

Right, but I think this is just another coding standards update along the lines of [54341] / #56667. This would bring more consistency, as get_author_posts_url() appears to be escaped in other bundled themes, as well as in other files of the same theme (two links are escaped and two are not, which is fixed by this patch).

So if that change went in, it seems like this should go in too :) Otherwise we'd have to bump the theme version just for [54341], and then bump it again just for this patch.

Yes, I also agree with you. because it is not a big change and some same patches were accepted so this patch also can be merged with 6.1

[hztyfoon]

Thanks @SergeyBiryukov,
I also agree.

As this is not a big/breaking change and as the similar mentioned ([54341] / #56667) patch already merged with 6.1, It'd be consistent if this one goes in with 6.1

Also,
I'm looking for more potential coding standard related changes and hoping to bring them to light to bring more consistency in the core codebase.

[audrasjb]

Alright, let's move it back to 6.1 then :)

I'll commit it right now so it's done.

[audrasjb]

In 54344:

Twenty Ten: Escape get_author_posts_url() where appropriate in functions.php file.

This changeset adds missing escaping to some instances of get_author_posts_url() used in Twenty Ten, as per WordPress Coding Standards.

Props hztyfoon, robinwpdeveloper, mukesh27, rudlinkon, SergeyBiryukov, jakariaistauk.
Fixes #56674.

committed in https://core.trac.wordpress.org/changeset/54344