Extra spaces appear in css queue

[elten]

In the css queue, there are two spaces between “id” and “href”, also have this problem in wordpress.org.

<link rel='stylesheet' id='wporg-global-fonts-css'  href='https://wordpress.org/wp-content/mu-plugins/pub-sync/global-fonts/style.css?ver=1663691227' media='all' />
<link rel='stylesheet' id='wporg-parent-2021-style-css'  href='https://wordpress.org/wp-content/themes/wporg-parent-2021/build/style.css?ver=1660938306' media='all' />
<link rel='stylesheet' id='wporg-main-2022-style-css'  href='https://wordpress.org/wp-content/themes/wporg-main-2022/build/style/style-index.css?ver=1663690308' media='all' />
<link rel='stylesheet' id='wporg-parent-block-styles-css'  href='https://wordpress.org/wp-content/themes/wporg-parent-2021/build/block-styles.css?ver=1661271656' media='all' />
<link rel='stylesheet' id='wporg-global-header-footer-css'  href='https://wordpress.org/wp-content/mu-plugins/pub-sync/blocks/global-header-footer/build/style.css?ver=1664222912' media='all' />

==========

WordPress version : 6.0.2
Appears after loading the css queue ( use wp_enqueue_style() ) .
The problem has nothing to do with templates.

[audrasjb]

Hello, welcome to WordPress Core Trac and thank you for opening this ticket!

The issue comes from ​this line. When the third %s placeholder is empty, two spaces are printed.

Trac ticket: https://core.trac.wordpress.org/ticket/56675

[whaze]

hello,
i submitted a PR : moving the space in the $title var to prevent double space beetween id and href attribute, so the space is still ok when link tag have a title attr

[whaze]

link tag with and without title attr

[audrasjb]

Looks great to me.
By the way, we should also update the related unit tests located in tests/phpunit/tests/dependencies/styles.php @whaze

[whaze]

@audrasjb
i updated the unit tests

[audrasjb]

Thanks @whaze, looks great.
Also, thanks @SergeyBiryukov for adding RTL support and for the few small enhancements ✌️

Let's ship this with 6.1.

[audrasjb]

In 54348:

Script Loader: Prevent double space between attributes in WP_Styles class.

This changeset prevents <link /> elements to display a double space between attributes when no title attribute is provided.

Props elten, audrasjb, whaze, SergeyBiryukov.
Fixes #56675.

committed in https://core.trac.wordpress.org/changeset/54348