#56692 closed task (blessed) (fixed)
Update GetID3 to version 1.9.22
| Reported by: |
|
Owned by: |
|
|---|---|---|---|
| Milestone: | 6.1 | Priority: | normal |
| Severity: | normal | Version: | 6.1 |
| Component: | External Libraries | Keywords: | php81 has-patch commit add-to-field-guide |
| Focuses: | Cc: |
Description (last modified by )
GetID3 1.9.22 has just been released and includes numerous bugfixes as well as various improvements for PHP 8.1 support.
The version included with WP should be updated.
Full details:
- https://github.com/JamesHeinrich/getID3/releases/tag/v1.9.22
- https://github.com/JamesHeinrich/getID3/compare/v1.9.21...v1.9.22
I've done a cursory review of the diff and didn't see anything which particularly worries me, but would recommend a second pair of eyes to review the diff as well.
All the same, I would strongly recommend an update at the earliest convenience due to the PHP 8.1 fixes being included.
Change History (11)
This ticket was mentioned in PR #3383 on WordPress/wordpress-develop by desrosj.
2 years ago
#4
- Keywords has-patch added; needs-patch removed
#5
@
2 years ago
I've created a PR to make it easier to see which changes will affect Core since only a subset of files are included. Everything looks relatively safe to me as well.
The only thing that seemed a bit weird was the addition of error suppression with @ in module.tag.id3v2.php. There are other instances in the library where @ is used in a similar fashion. I'm guessing this is just because the library currently supporting PHP 5.0.5 and up for versions 1.8.x and up.
@jrf could you give my PR a sanity check before I commit?
#6
@
2 years ago
- Keywords commit added
I'd like to get this in before beta 3, so going to commit after just looking through it once more.
#9
@
2 years ago
@desrosj Sorry, I didn't manage to get to this PR today. If you like, I'll have a look tomorrow early to confirm all is okay.
Trac ticket: https://core.trac.wordpress.org/ticket/56692