Make WordPress Core

Opened 20 months ago

Closed 20 months ago

Last modified 20 months ago

#56692 closed task (blessed) (fixed)

Update GetID3 to version 1.9.22

Reported by: jrf's profile jrf Owned by: desrosj's profile desrosj
Milestone: 6.1 Priority: normal
Severity: normal Version: 6.1
Component: External Libraries Keywords: php81 has-patch commit add-to-field-guide
Focuses: Cc:

Description (last modified by jrf)

GetID3 1.9.22 has just been released and includes numerous bugfixes as well as various improvements for PHP 8.1 support.

The version included with WP should be updated.

Full details:

I've done a cursory review of the diff and didn't see anything which particularly worries me, but would recommend a second pair of eyes to review the diff as well.

All the same, I would strongly recommend an update at the earliest convenience due to the PHP 8.1 fixes being included.

Previously: [47601], [48278], #54162 - [52254]

Change History (11)

#1 @jrf
20 months ago

  • Description modified (diff)

#2 @jrf
20 months ago

  • Description modified (diff)

#3 @desrosj
20 months ago

  • Owner set to desrosj
  • Status changed from new to reviewing

This ticket was mentioned in PR #3383 on WordPress/wordpress-develop by desrosj.

20 months ago

  • Keywords has-patch added; needs-patch removed

#5 @desrosj
20 months ago

I've created a PR to make it easier to see which changes will affect Core since only a subset of files are included. Everything looks relatively safe to me as well.

The only thing that seemed a bit weird was the addition of error suppression with @ in module.tag.id3v2.php. There are other instances in the library where @ is used in a similar fashion. I'm guessing this is just because the library currently supporting PHP 5.0.5 and up for versions 1.8.x and up.

@jrf could you give my PR a sanity check before I commit?

#6 @desrosj
20 months ago

  • Keywords commit added

I'd like to get this in before beta 3, so going to commit after just looking through it once more.

#7 @desrosj
20 months ago

  • Resolution set to fixed
  • Status changed from reviewing to closed

In 54376:

External Libraries: Update getID3 to version 1.9.22.

This updates the getID3 library from version 1.9.21 to 1.9.22, which contains a number of bug fixes and improvements to PHP 8.1 support.

A full list of changes can be found on GitHub:

Props jrf, desrosj.
Fixes #56692.

#9 @jrf
20 months ago

@desrosj Sorry, I didn't manage to get to this PR today. If you like, I'll have a look tomorrow early to confirm all is okay.

#10 @desrosj
20 months ago

No worries! I wanted to have it included in beta 3 so that it could benefit from some wider testing and reverted if need be prior to RC1 next week.

Another review at any time would be great just to confirm I didn't miss something.

#11 @milana_cap
20 months ago

  • Keywords add-to-field-guide added
Note: See TracTickets for help on using tickets.