Make WordPress Core

Opened 2 years ago

Closed 7 months ago

#56695 closed defect (bug) (fixed)

Twenty Eleven: Pullquote block ignores font weight and style settings

Reported by: nidhidhandhukiya's profile nidhidhandhukiya Owned by: karmatosed's profile karmatosed
Milestone: 6.6 Priority: normal
Severity: normal Version: 6.0.2
Component: Bundled Theme Keywords: has-patch commit
Focuses: css Cc:

Description

Activate theme Twenty Eleven.
Choose Pullquote block.
Give font style and weight from the appearance.
I have attached video for better undestanding.
Video URL :- https://share.cleanshot.com/vjHrOF1a5qy0dVuqsHBH

Attachments (5)

56695.patch (499 bytes) - added by nidhidhandhukiya 2 years ago.
56695.2.patch (1.4 KB) - added by nidhidhandhukiya 10 months ago.
Updated the patch, This patch can reoslve the issue for both Pullquote & Quote block.
56695.3.patch (2.3 KB) - added by sabernhardt 10 months ago.
Pullquote and Quote: inheriting font-weight when block changes weight, font-style when block has special style
SCR-20240621-npxx.png (38.9 KB) - added by karmatosed 7 months ago.
With patch showing bold applied
SCR-20240621-nqap.png (39.6 KB) - added by karmatosed 7 months ago.
Without patch and same style but bold not showing on front

Download all attachments as: .zip

Change History (15)

#1 @nidhidhandhukiya
2 years ago

  • Keywords has-patch added

#2 @desrosj
2 years ago

  • Summary changed from Twenty Eleven theme pull quote block font weight and style is not working proper. to Twenty Eleven: pull quote block font weight and style is not working properly

#3 @karmatosed
10 months ago

  • Keywords reporter-feedback added

@nidhidhandhukiya are you still able to see this working in the latest release as in testing the patch it didn't seem to reflect the changes sadly for me. It would be great as a result to get a check and refresh of the patch if possible. I can confirm the issue, but I only get the citation changing still even with patch applied.

@nidhidhandhukiya
10 months ago

Updated the patch, This patch can reoslve the issue for both Pullquote & Quote block.

#4 @karmatosed
10 months ago

  • Keywords needs-testing added

@sabernhardt
10 months ago

Pullquote and Quote: inheriting font-weight when block changes weight, font-style when block has special style

#5 @sabernhardt
10 months ago

  • Keywords reporter-feedback removed
  • Summary changed from Twenty Eleven: pull quote block font weight and style is not working properly to Twenty Eleven: Pullquote block ignores font weight and style settings

#6 @karmatosed
9 months ago

  • Milestone changed from Awaiting Review to Future Release

#7 @karmatosed
7 months ago

This looks good to me in testing as can be seen from the screenshots. I am going to go ahead and commit this, thank you everyone.

@karmatosed
7 months ago

With patch showing bold applied

@karmatosed
7 months ago

Without patch and same style but bold not showing on front

#8 @karmatosed
7 months ago

  • Keywords commit added; needs-testing removed
  • Milestone changed from Future Release to 6.6

#9 @karmatosed
7 months ago

  • Owner set to karmatosed
  • Status changed from new to assigned

#10 @karmatosed
7 months ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 58453:

Twenty Eleven: Resolves pullquote block ignoring font weight and style settings.

The pullquote block was ignoring font weight and style settings. This now brings in a fix using inherit.

Props nidhidhandhukiya, desrosj, sabernhardt.
Fixes #56695.

Note: See TracTickets for help on using tickets.