#56702 closed defect (bug) (fixed)
Twenty Seventeen: Update jQuery scrollTo to the latest version
Reported by: | desrosj | Owned by: | sarahricker |
---|---|---|---|
Milestone: | 6.1 | Priority: | normal |
Severity: | normal | Version: | |
Component: | Bundled Theme | Keywords: | good-first-bug has-patch commit |
Focuses: | Cc: |
Description
The scrollTo jQuery plugin is included in Twenty Seventeen, currently at version 2.1.2. Version 2.1.3 is now available, so this should be updated.
In 2.1.3, jQuery.isFunction
is removed since it has been deprecated.
Change History (11)
This ticket was mentioned in PR #3381 on WordPress/wordpress-develop by sarahricker.
2 years ago
#2
- Keywords has-patch added; needs-patch removed
#3
@
2 years ago
- Keywords needs-testing added
- Owner set to sarahricker
- Status changed from new to accepted
#4
@
2 years ago
- Keywords changes-requested added; needs-testing removed
Added review notes on the PR.
sarahricker commented on PR #3381:
2 years ago
#5
Thanks @desrosj! The reason for the excessive changes is actually that we don't seem to have a true copy of 2.1.2. If you checkout before commit 18fb646 and compare our version to the file in jquery.scrollTo/releases/tag/2.1.2 and run a diff, there is quite a difference. ☹️
As such, we should probably do some extra testing to be sure other stuff isn't breaking. But, it's probably good to get the true version in there - what do you think?
I'll work on updating the version specified in the wp_enqueue_script() call in functions.php in the meantime. Thanks for the catch!
sarahricker commented on PR #3381:
2 years ago
#11
Awesome, thanks!
Trac ticket: https://core.trac.wordpress.org/ticket/56702
Updating scrollTo jQuery plugin included in Twenty Seventeen, from version 2.1.2 to version 2.1.3.
Testing Note:
In 2.1.3, jQuery.isFunction is removed since it has been deprecated.
A full list of changes can be found on GitHub.