Opened 2 years ago
Closed 2 years ago
#56703 closed task (blessed) (fixed)
Update the Dashboard welcome banner for 6.1
Reported by: |
|
Owned by: |
|
---|---|---|---|
Milestone: | 6.1 | Priority: | high |
Severity: | normal | Version: | |
Component: | Administration | Keywords: | has-patch commit dev-reviewed |
Focuses: | accessibility | Cc: |
Description
The Dashboard's welcome panel currently shows the "6.0" background image. It will need to be updated for 6.1, at least the image asset. Any string changes would need to happen ASAP (before beta 3 on Oct 4, unless this is considered part of the "About" strings).
For the past few releases, this design has matched the About page design (the 6.1 About page is tracked at #56357).
See #55532 for the previous update.
Attachments (2)
Change History (40)
This ticket was mentioned in Slack in #design by ryelle. View the logs.
2 years ago
#4
@
2 years ago
@richtabor and myself whipped up many concepts for the Dashboard welcome banner for 6.1
See threads.
https://wordpress.slack.com/archives/C02S78ZAL/p1664551500695589
https://wordpress.slack.com/archives/C02S78ZAL/p1664915916310249
This ticket was mentioned in Slack in #core by chaion07. View the logs.
2 years ago
#6
@
2 years ago
- Keywords needs-design-feedback added; needs-design removed
@chaion07 and I looked at this ticket during triage today.
Thanks @ryelle for creating the ticket for tracking, and @adampickering and @richtabor for the designs!
Swapping keyword for needs-design-feedback
since there are designs posted for review now.
Looks like there's some good conversation happening over on Slack.
This ticket was mentioned in Slack in #core by desrosj. View the logs.
2 years ago
#8
@
2 years ago
- Keywords needs-design added; needs-design-feedback removed
Updating the keywords back to needs-design
, the designs posted were for the About page headers. The design here will be related, but isn't done yet. The dashboard page designs could also reflect the chosen admin color scheme.
Since we'll be past hard string freeze, we can only change the style (background of the header).
This ticket was mentioned in Slack in #core by jeffpaul. View the logs.
2 years ago
This ticket was mentioned in Slack in #core by chaion07. View the logs.
2 years ago
This ticket was mentioned in PR #3483 on WordPress/wordpress-develop by @ryelle.
2 years ago
#11
- Keywords has-patch added
Apply the "About page" style update to the Welcome panel on the dashboard. This includes the 6.1 bubble image which is also added via https://github.com/WordPress/wordpress-develop/pull/3461.
This also updates the design to match the current color scheme. I'll link to screenshots, to avoid image-dumping in the ticket.
Default, Blue, Coffee, Ectoplasm, Light, Midnight, Modern, Ocean, Sunrise.
And on small screens, the background disappears. Default, Blue, Coffee, Ectoplasm, Light, Midnight, Modern, Ocean, Sunrise.
Trac ticket: https://core.trac.wordpress.org/ticket/56703
@richtabor commented on PR #3483:
2 years ago
#13
@richtabor commented on PR #3483:
2 years ago
#14
I think they look ace ✨
#16
@
2 years ago
- Keywords commit dev-feedback added; needs-design-feedback removed
design approved, now it just needs 2nd committer sign off.
#17
@
2 years ago
- Keywords dev-reviewed added; dev-feedback removed
LGTM! @ryelle If you want to get this in before RC2, go for it!
#18
@
2 years ago
- Owner set to davidbaumwald
- Resolution set to fixed
- Status changed from new to closed
In 54638:
@davidbaumwald commented on PR #3483:
2 years ago
#19
Merged into core in https://core.trac.wordpress.org/changeset/54638.
#21
@
2 years ago
In the latest commit the 6.0 header image was added, was this by intension? Running trunk now displays 6.0 in the welcome banner background, and in the header of about.php …
#22
@
2 years ago
- Keywords needs-patch added; has-patch removed
- Resolution fixed deleted
- Status changed from closed to reopened
This ticket was mentioned in Slack in #core by kebbet. View the logs.
2 years ago
This ticket was mentioned in PR #3494 on WordPress/wordpress-develop by @kebbet.
2 years ago
#24
- Keywords has-patch added; needs-patch removed
#25
@
2 years ago
It's incorrect in 6.1 branch too.
-> https://core.trac.wordpress.org/browser/branches/6.1/src/wp-admin/images/about-header-about.svg
@SergeyBiryukov commented on PR #3494:
2 years ago
#27
Thanks for the PR! Merged in r54645.
#28
@
2 years ago
- Keywords dev-feedback added
Marking [54645] for backporting to the 6.1 branch after a second committer's review.
#29
@
2 years ago
- Keywords dev-reviewed added; dev-feedback removed
Looks good, I can do the backport commit.
#31
@
2 years ago
- Focuses accessibility added
- Keywords commit dev-reviewed removed
- Resolution fixed deleted
- Status changed from closed to reopened
The SVG still needs aria-hidden
, as it has had in 6.0 (changeset:53383 / ticket:55532#comment:13).
I'd also like to consider changing each path
element to circle
and removing the clip-path
so the image can be much smaller. (I could convert the Freedoms image to circles, too, but the Credits and Privacy SVGs are more complicated.)
@
2 years ago
adding aria-hidden
, focusable
and viewBox
attributes; removing clip-path
; converting path
elements to circle
This ticket was mentioned in Slack in #accessibility by ryokuhi. View the logs.
2 years ago
#33
@
2 years ago
- Keywords needs-design-feedback added
We reviewed this ticket today during the Accessibility Team's weekly bug scrub.
The changes suggested by @sabernhardt regarding the aria-hidded
, the focusable
, and the viewBox
attributes are needed.
Regarding the use of circle
s instead of path
s, such a change would make the file sizes much smaller.
It would probably be easier if someone from the Design Team with the source files could make these changes.
#34
@
2 years ago
- Keywords commit added; needs-design-feedback removed
Patch 56703.diff looks good, I don't see any visual change from using circle
and the file is notably smaller. I'm going to move the conversation about the other About images over to the About page ticket though.
Current dashboard widget