Changes between Version 1 and Version 2 of Ticket #56713, comment 5
- Timestamp:
- 10/17/2022 12:37:51 AM (3 years ago)
Legend:
- Unmodified
- Added
- Removed
- Modified
-
Ticket #56713, comment 5
v1 v2 35 35 Therefore, wrapping each of these calls to `$wp_filesystem->chmod()` with an `! $wp_filesystem->is_writable()` check should make sure that `chmod()` is only run when the path is not writable. This is done in most other places in Core, but not all. 36 36 37 Wrapping various `chmod()` calls with `if ( $wp_filesystem->is_writable() ) {}` and defining `FS_METHOD` as `direct` seems to update just fine for me.37 Wrapping various `chmod()` calls with `if ( ! $wp_filesystem->is_writable() ) {}` and defining `FS_METHOD` as `direct` seems to update just fine for me. 38 38 39 39 The `chmod()` calls I found to be relevant to this issue are: