WordPress.org
Get WordPress

Make WordPress Core

Opened 3 years ago

Closed 2 years ago

#56720 closed enhancement (fixed)

Twenty Twenty-Two: Remove color reference from pattern names

Reported by: poena's profile poena Owned by: audrasjb's profile audrasjb
Milestone: 6.2 Priority: normal
Severity: normal Version: 5.9
Component: Bundled Theme Keywords: has-patch commit
Focuses: Cc:

Description (last modified by poena)

This ticket is copied to core trac from Gutenberg:​40033

There are a few block patterns in the theme that includes colors in the pattern name, but when the user changes the colors, the name no longer match.

The suggested fix in the discussion on GitHub is to remove the color from the pattern names and instead of "with salmon background", the name would be "with background".

Attachments (2)

56720.diff​ (7.7 KB) - added by poena 3 years ago.
Update block pattern names
Screenshot 2022-11-26 at 5.08.04 PM.png​ (85.7 KB) - added by mukesh27 2 years ago.

Download all attachments as: .zip

Change History (11)

@poena
3 years ago

Update block pattern names

#1 @poena
3 years ago

  • Keywords has-patch added
  • Milestone changed from Future Release to 6.2
  • Version set to 5.9

#2 @poena
3 years ago

  • Description modified (diff)

#3 @poena
3 years ago

  • Description modified (diff)

@mukesh27
2 years ago

#4 @mukesh27
2 years ago

Thanks @poena. 56720.diff​ changes LGTM.

  1. DO we needs to remove color from pattern file name?

Check attached screenshot.

This ticket was mentioned in ​Slack in #core by mukeshpanchal27. ​View the logs.
2 years ago

#6 @poena
2 years ago

I don't think the file names matter as they are not exposed to users the same way.
They would only be used by advanced users or developers who customize the theme files directly.

#7 @mukesh27
2 years ago

  • Keywords commit added

This ticket was discussed in the recent bug scrub.

Thanks for the answer @poena. Make sense.

commit added.

Props to @costdev

#8 @audrasjb
2 years ago

  • Owner set to audrasjb
  • Status changed from new to reviewing

#9 @audrasjb
2 years ago

  • Resolution set to fixed
  • Status changed from reviewing to closed

In 55122:

Twenty Twenty-Two: Remove color reference from pattern names.

This changeset removes color names from pattern names to make them less opinionated, and avoid mismatching when the user changes related colors. It does not update filenames for now, as they are not directly exposed to end users.

Props poena, mukesh27.
Fixes #56720.

Note: See TracTickets for help on using tickets.